Code review comment for lp:~pitti/messaging-app/phonesim-tests

Revision history for this message
Martin Pitt (pitti) wrote :

Discussed with Francis on IRC. I dropped the conflicts:, as our current CI machinery always installs all binaries, and does not have any configuration for the connected tests. Please note that the connected tests immediately crash with

  File "/home/phablet/messaging-app/tests/autopilot/messaging_app_connected/tests/__init__.py", line 43, in <module>
    class MessagingAppConnectedTestCase(MessagingAppTestCase):
  File "/home/phablet/messaging-app/tests/autopilot/messaging_app_connected/tests/__init__.py", line 52, in MessagingAppConnectedTestCase
    PHONE_NUMBER = config.get('connected_variables', 'dial_number')
  File "/usr/lib/python2.7/ConfigParser.py", line 607, in get
    raise NoSectionError(section)
NoSectionError: No section: 'connected_variables'

if there is no actual configuration file. This should be cleaned up, but the test is currently written in a way which runs a lot of static code which doesn't get skipped by testtools.skipIf() properly.

« Back to merge proposal