Code review comment for lp:~pitti/indicator-session/libupower-glib

Revision history for this message
Martin Pitt (pitti) wrote :

Well, the client-side library (libdevkit-power-gobject, and now libupower-glib) is _the_ official API for upower, which is also being used by gnome-power-manager, gnome-session, etc. So this is more stable than the upower D-Bus API (even now you can still use libdevkit-power-gobject and it will transparently use upower).

The obvious disadvantage that this patch brings is that it now introduces a dependency on a new library. I don't personally see a problem with it, but if you want to support upstream releases which build without dk-power/upower, I'm happy to add some configure autodetection and just disable the suspend/hibernate bits if libupower-glib is not available.

« Back to merge proposal