Code review comment for lp:~pitti/gtimelog/pygi

Revision history for this message
Marius Gedminas (mgedmin) wrote :

Awesome!

But something seems to be wrong: the diff is empty. Have you pushed your changes to the launchpad branch?

Is it possible to have one codebase that uses either PyGtk or PyGI? I'd like GTimeLog to continue working with older distributions like Lucid.

The icon color detection is an ugly hack. I think the proper solution is to install different versions of gtimelog.png into /usr/share/icons/ubutu-mono-{dark,light}, and perhaps a colourful one into /usr/share/icons/hicolor.

The hack is there mostly because development is easier if I can run gtimelog (and see its icon) directly from a source checkout.

« Back to merge proposal