Merge lp:~pitti/autopilot-gtk/unsupported-type-warning into lp:autopilot-gtk

Proposed by Martin Pitt
Status: Merged
Approved by: Martin Pitt
Approved revision: 68
Merged at revision: 68
Proposed branch: lp:~pitti/autopilot-gtk/unsupported-type-warning
Merge into: lp:autopilot-gtk
Diff against target: 12 lines (+1/-1)
1 file modified
lib/Variant.cpp (+1/-1)
To merge this branch: bzr merge lp:~pitti/autopilot-gtk/unsupported-type-warning
Reviewer Review Type Date Requested Status
Víctor R. Ruiz (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+200641@code.launchpad.net

Commit message

Tone down "unsupported type" warning into a debug message.

Description of the change

This warning actually has never been meant to be a warning, but a debug
message. Suppress it by default, and only let it appear with G_MESSAGES_DEBUG,
as the autopilot user can't do anything about it anyway and this creates a lot
of clutter in logs.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/Variant.cpp'
--- lib/Variant.cpp 2013-09-04 05:21:51 +0000
+++ lib/Variant.cpp 2014-01-07 09:29:26 +0000
@@ -329,7 +329,7 @@
329 }329 }
330 break;330 break;
331 default:331 default:
332 g_warning("unsupported type: %s", g_type_name(G_VALUE_TYPE(value)));332 g_debug("unsupported type: %s", g_type_name(G_VALUE_TYPE(value)));
333 {}333 {}
334 break;334 break;
335 }335 }

Subscribers

People subscribed via source and target branches

to all changes: