Merge lp:~pimvullers/audience/fix-1003911 into lp:~audience-members/audience/trunk

Proposed by Pim Vullers
Status: Merged
Merged at revision: 188
Proposed branch: lp:~pimvullers/audience/fix-1003911
Merge into: lp:~audience-members/audience/trunk
Diff against target: 17 lines (+5/-2)
1 file modified
Audience/Widgets/Button.vala (+5/-2)
To merge this branch: bzr merge lp:~pimvullers/audience/fix-1003911
Reviewer Review Type Date Requested Status
Cody Garver Approve
Review via email: mp+112670@code.launchpad.net

Commit message

Description of the change

Fixed bug #1003911 by avoiding null pointer dereferencing.

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Audience/Widgets/Button.vala'
2--- Audience/Widgets/Button.vala 2012-05-19 15:57:37 +0000
3+++ Audience/Widgets/Button.vala 2012-06-28 23:26:19 +0000
4@@ -33,8 +33,11 @@
5
6 var ti = new ThemedIcon.from_names ({icon, alt_fallback, fallback});
7 var l = Gtk.IconTheme.get_default ().lookup_by_gicon (ti, 16, 0);
8- this.set_from_pixbuf (l.load_symbolic ({1.0,1.0,1.0,1.0}, null, null, null, null));
9-
10+ if (l != null) {
11+ this.set_from_pixbuf (l.load_symbolic ({1.0,1.0,1.0,1.0}, null, null, null, null));
12+ } else {
13+ warning("NULL detected when trying to load icon: " + icon + " (or " + fallback + ")");
14+ }
15 } catch (Error e){warning (e.message);}
16 }
17 }

Subscribers

People subscribed via source and target branches

to all changes: