Segmentation fault when starting audience

Bug #1003911 reported by Pim Vullers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Audience
Fix Released
Medium
Pim Vullers

Bug Description

When starting audience I get the following error:

pim@chaos ~ $ audience
[INFO 14:16:14.403456] [Application:74] Audience version: 0.1
[INFO 14:16:14.403584] [Application:76] Kernel version: 3.3.6-hardened-r1
[WARN 14:16:14.427410] [Gtk] Theme parsing error: gtk-widgets.css:200:23: 'px' is not a valid color name
[WARN 14:16:14.427602] [Gtk] Theme parsing error: gtk-widgets.css:201:23: 'px' is not a valid color name
[WARN 14:16:14.427867] [Gtk] Theme parsing error: gtk-widgets.css:231:23: 'px' is not a valid color name
[WARN 14:16:14.428016] [Gtk] Theme parsing error: gtk-widgets.css:232:23: 'px' is not a valid color name
[WARN 14:16:14.502335] [Gtk] Theme parsing error: button.css:164:23: 'px' is not a valid color name
[WARN 14:16:14.502507] [Gtk] Theme parsing error: button.css:165:23: 'px' is not a valid color name
[WARN 14:16:14.514673] [Gtk] Theme parsing error: content-view.css:62:23: 'px' is not a valid color name
[WARN 14:16:14.514858] [Gtk] Theme parsing error: content-view.css:68:23: 'px' is not a valid color name
[WARN 14:16:14.515068] [Gtk] Theme parsing error: content-view.css:80:23: 'px' is not a valid color name
[DEBUG 14:16:14.527945] [Settings:155] Loading settings from schema 'org.pantheon.Audience'
Segmentation fault
pim@chaos ~ $

The backtrace with gdb gives this:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff73d7b27 in gtk_icon_info_load_symbolic ()
   from /usr/lib64/libgtk-3.so.0
(gdb) bt
#0 0x00007ffff73d7b27 in gtk_icon_info_load_symbolic () from /usr/lib64/libgtk-3.so.0
#1 0x000055555556cd1b in audience_widgets_button_set_icon ()
#2 0x000055555556cf17 in audience_widgets_button_construct ()
#3 0x0000555555570689 in audience_widgets_top_panel_construct ()
#4 0x0000555555563486 in audience_app_construct ()
#5 0x0000555555566a30 in _vala_main ()
#6 0x0000555555566aa9 in main ()

Audience from trunk with Gtk+ 3.4.3 build on Gentoo Linux Hardened x64.

Related branches

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

Hm.. which icon theme do you use?

Revision history for this message
Pim Vullers (pimvullers) wrote : Re: [Bug 1003911] Re: Segmentation fault when starting audience

Elementary

Revision history for this message
Pim Vullers (pimvullers) wrote :

I investigated this a bit, and it seemed nautilus also suffered from this (see http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/gnome-base/nautilus/files/nautilus-3.0.2-segfault-in-gtk_icon_info_load_symbolic.patch). Building audience with debug showed that the NULL pointer is passed in Widgets/Button.vala:36.

When I modify that piece to:
                if (l != null) {
                    this.set_from_pixbuf (l.load_symbolic ({1.0,1.0,1.0,1.0}, null, null, null, null));
                } else {
                    warning("NULL detected when trying to load icon: " + icon + " (or " + fallback + ")");
                }

Running audience with these lines does no longer segfault, however, it prints the following message:
[WARN 22:03:25.452287] [Button:39] NULL detected when trying to load icon: view-restore-symbolic (or gtk-leave-fullscreen)

I've got this icon available at /usr/share/icons/gnome/scalable/actions/view-restore-symbolic.svg (it's not in elementary theme neither is the fallback, which is again available in gnome).

So this is kind of a theming issue, but with such checks for null we can prevent crashes. We only need to think about what to do when the icon is not available.

Changed in audience:
importance: Undecided → Medium
Revision history for this message
Pim Vullers (pimvullers) wrote :

Tom, which icon theme do you use? And which other themes do you have installed.

Does the elementary theme provide these icons in your case, or which theme does?

Revision history for this message
Pim Vullers (pimvullers) wrote :

Thanks to Daniel Fore the elementary icon theme now has these icons (see bug #1018702). However I still think we should merge this branch to avoid crashing for users who do not use gnome or elementary icon theme.

Cody Garver (codygarver)
Changed in audience:
assignee: nobody → Pim Vullers (pimvullers)
status: New → Fix Committed
milestone: none → 0.1
Changed in audience:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.