Merge ~pieq/plainbox-provider-certification-client:remove-xorg-jobs-from-test-plans into plainbox-provider-certification-client:master

Proposed by Pierre Equoy
Status: Merged
Approved by: Pierre Equoy
Approved revision: 7c65ef05b5c1a45e15daa3f4b52058f8f84b8dc3
Merged at revision: 4713bbbcff2cbe108d8c6d2ac62a637f0261741e
Proposed branch: ~pieq/plainbox-provider-certification-client:remove-xorg-jobs-from-test-plans
Merge into: plainbox-provider-certification-client:master
Diff against target: 35 lines (+0/-6)
2 files modified
units/client-cert-desktop-hwe-sru.pxu (+0/-3)
units/client-cert-desktop-n+1.pxu (+0/-3)
Reviewer Review Type Date Requested Status
Sylvain Pineau Approve
Review via email:

Description of the change

See commit message and linked issue for more info.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Are those testplans that you change here ran only on 22.04?

Revision history for this message
Pierre Equoy (pieq) wrote :

No, they run on 20.04 as well. A while back, we had a discussion with Sylvain, and the conclusion was that these jobs (xorg-*) did not provide a lot of added-value. I don't think any devices was ever prevented to be certified because of a problem with xorg.

So the conclusion was to drop them completely.

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

I confirm, all these xorg jobs can go away

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/client-cert-desktop-hwe-sru.pxu b/units/client-cert-desktop-hwe-sru.pxu
2index af105df..7fded7b 100644
3--- a/units/client-cert-desktop-hwe-sru.pxu
4+++ b/units/client-cert-desktop-hwe-sru.pxu
5@@ -30,7 +30,6 @@ include:
6 info/audio_device_driver
7 info/network_devices
8 # Automated requisite tests for the manual ones
9- graphics/xorg-version certification-status=blocker
10 graphics/VESA_drivers_not_in_use certification-status=blocker
11 # Manual tests
12 monitor/1_vga.* certification-status=blocker
13@@ -43,8 +42,6 @@ include:
14 monitor/1_thunderbolt.*
15 monitor/1_dim_brightness.* certification-status=blocker
16 # Automated tests
17- graphics/xorg-failsafe certification-status=blocker
18- graphics/xorg-process certification-status=blocker
19 graphics/1_maximum_resolution_.* certification-status=blocker
20 graphics/1_glxgears_.* certification-status=blocker
21 graphics/1_driver_version_.* certification-status=blocker
22diff --git a/units/client-cert-desktop-n+1.pxu b/units/client-cert-desktop-n+1.pxu
23index c5e572e..b0c5d44 100644
24--- a/units/client-cert-desktop-n+1.pxu
25+++ b/units/client-cert-desktop-n+1.pxu
26@@ -68,9 +68,6 @@ include:
27 monitor/1_vga_.* certification-status=blocker
28 monitor/1_multi-head_.* certification-status=blocker
29 # See Graphic Tests section for monitor test on second graphic card
30- graphics/xorg-version certification-status=blocker
31- graphics/xorg-failsafe certification-status=blocker
32- graphics/xorg-process certification-status=blocker
33 graphics/VESA_drivers_not_in_use certification-status=blocker
34 graphics/1_maximum_resolution_.* certification-status=blocker
35 graphics/1_glxgears_.* certification-status=blocker


People subscribed via source and target branches