Merge ~pieq/checkbox-support:1658624-fwts-tests-list-update into checkbox-support:master

Proposed by Pierre Equoy
Status: Merged
Approved by: Sylvain Pineau
Approved revision: ef7975cb957384562885a9c6074d68e90bd1d96b
Merged at revision: ecc438b440f54f3c1ad5c772755a3c118fe429e4
Proposed branch: ~pieq/checkbox-support:1658624-fwts-tests-list-update
Merge into: checkbox-support:master
Diff against target: 128 lines (+20/-59)
1 file modified
checkbox_support/scripts/fwts_test.py (+20/-59)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+315445@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Thanks for keeping our wrapper up to date. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/checkbox_support/scripts/fwts_test.py b/checkbox_support/scripts/fwts_test.py
2index 6d93882..c78514f 100644
3--- a/checkbox_support/scripts/fwts_test.py
4+++ b/checkbox_support/scripts/fwts_test.py
5@@ -18,60 +18,35 @@ INTERACTIVE_TESTS = ['ac_adapter',
6 'power_button',
7 'brightness',
8 'lid']
9+# Tests recommended by the Hardware Enablement Team (HWE)
10 # These are performed on QA certification runs
11 QA_TESTS = ['acpitests',
12- 'acpidump',
13- 'acpitables',
14- 'apicinstance',
15+ 'apicedge',
16 'aspm',
17- 'bios32',
18+ 'cpufreq',
19 'dmicheck',
20- 'ebda',
21- 'mpcheck',
22+ 'esrt',
23+ 'klog',
24+ 'maxfreq',
25 'msr',
26+ 'mtrr',
27 'nx',
28- 'version']
29-# These are advanced tests that shouldn't affect certification status
30-NON_CERT_TESTS = ['bios_info',
31- 'cmosdump',
32- 'cpufreq',
33- 'crs',
34- 'crsdump',
35- 'csm',
36- 'ebdadump',
37- 'fan',
38- 'gpedump',
39- 'hda_audio',
40- 'maxfreq',
41- 'maxreadreq',
42- 'memmapdump',
43- 'microcode',
44- 'mpdump',
45- 'os2gap',
46- 'osilinux',
47- 'pciirq',
48- 'plddump',
49- 'pnp',
50- 'prsdump',
51- 'romdump',
52- 'securebootcert',
53- 'syntaxcheck',
54- 'uefidump',
55- 'uefirtmisc',
56- 'uefirttime',
57- 'uefirtvariable',
58- 'uefivarinfo',
59- 'wakealarm'
60- ]
61+ 'oops',
62+ 'uefibootpath',
63+ 'uefirtmisc',
64+ 'uefirttime',
65+ 'uefirtvariable',
66+ 'version',
67+ 'virt']
68 # The following tests will record logs in a separate file for the HWE team
69-HWE_TESTS = ['mtrr',
70+HWE_TESTS = ['version',
71+ 'mtrr',
72 'virt',
73 'apicedge',
74 'klog',
75- 'oops',
76- 'uefibootpath']
77-CERT_TESTS = sorted(QA_TESTS + HWE_TESTS)
78-TESTS = sorted(QA_TESTS + NON_CERT_TESTS + HWE_TESTS)
79+ 'oops']
80+# By default, we launch all the tests
81+TESTS = sorted(list(set(QA_TESTS + HWE_TESTS)))
82
83
84 def get_sleep_times(start_marker, end_marker, sleep_time, resume_time):
85@@ -236,12 +211,6 @@ def main():
86 group.add_argument('--list',
87 action='store_true',
88 help='List all tests in fwts.')
89- group.add_argument('--list-cert',
90- action='store_true',
91- help='List all certification tests in fwts.')
92- group.add_argument('--list-advanced',
93- action='store_true',
94- help='List all advanced tests in fwts.')
95 group.add_argument('--list-hwe',
96 action='store_true',
97 help='List all HWE concerned tests in fwts')
98@@ -282,12 +251,6 @@ def main():
99 elif args.list:
100 print('\n'.join(TESTS))
101 return 0
102- elif args.list_cert:
103- print('\n'.join(CERT_TESTS))
104- return 0
105- elif args.list_advanced:
106- print('\n'.join(NON_CERT_TESTS))
107- return 0
108 elif args.list_hwe:
109 print('\n'.join(HWE_TESTS))
110 return 0
111@@ -296,8 +259,6 @@ def main():
112 return 0
113 elif args.test:
114 tests.extend(args.test)
115- elif args.all:
116- tests.extend(TESTS)
117 elif args.hwe:
118 tests.extend(HWE_TESTS)
119 elif args.qa:
120@@ -335,7 +296,7 @@ def main():
121 args.resume_time = 3
122 tests.extend(args.sleep)
123 else:
124- tests.extend(CERT_TESTS)
125+ tests.extend(TESTS)
126
127 # run the tests we want
128 if args.sleep:

Subscribers

People subscribed via source and target branches