Merge ~pieq/bugit/+git/qabro:fix-1910193-no-pci-bus into bugit:master
Proposed by
Pierre Equoy
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Pierre Equoy | ||||
Approved revision: | 78c1933fe61dbf17b0d027e89f22e29ea99ade35 | ||||
Merged at revision: | 44b3acd84a216fba15eb076747034610f45ee309 | ||||
Proposed branch: | ~pieq/bugit/+git/qabro:fix-1910193-no-pci-bus | ||||
Merge into: | bugit:master | ||||
Diff against target: |
76 lines (+19/-12) 2 files modified
qabro/bug_assistant.py (+15/-10) qabro/utils.py (+4/-2) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Patrick Liu (community) | Approve | ||
Review via email:
|
Description of the change
As explained in lp:1910193, if the device does not have a PCI bus, calling lspci will fail and qabro will fail to launch.
This commit fixes that by checking the returncode from the lspci command.
I tested it on a regular amd64 PC with a proper PCI bus by building a test snap and it works (so it means no regression so far), but I haven't been able to test it on a no-PCI bus device...
To post a comment you must log in.
+1 LGTM