Merge ~pieq/bugit/+git/qabro:modal-error-window into bugit:master
Proposed by
Pierre Equoy
Status: | Merged |
---|---|
Approved by: | Pierre Equoy |
Approved revision: | cdd37eaf5051d3f75d9f69fb40f155e0315de010 |
Merged at revision: | 5965e5f78bf5d2593c98910c2b3f21209bf3e254 |
Proposed branch: | ~pieq/bugit/+git/qabro:modal-error-window |
Merge into: | bugit:master |
Diff against target: |
86 lines (+23/-8) 2 files modified
qabro/__init__.py (+1/-2) qabro/ui.py (+22/-6) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Maciej Kisielewski (community) | Approve | ||
Nara Huang (community) | Approve | ||
Review via email: mp+386549@code.launchpad.net |
Description of the change
See commit message for more info.
To test (on Ubuntu classic):
1. Run `snapcraft` from this branch to build a `qabro_
2. Install the snap:
sudo snap install qabro_0.
3. Run `qabro`
4. Try to generate an error (for instance, leave the "Title" field blank and press `Alt+Enter` to try to submit the report)
→ You should see a modal error dialog popping up in red, with a 'OK' button to dismiss it (you can also press Esc key).
To post a comment you must log in.
Tested, the new error window is great, LGTM.