Code review comment for ~philroche/ubuntu/+source/google-guest-agent:feature/ubuntu/mantic-devel-no-start-services-on-upgrade

Revision history for this message
Philip Roche (philroche) wrote :

> 1. reworking the changelog entry to state more correctly what we do (e.g. not restoring)

ack

> 2. once proven stating why it is a problem in jammy now, but not in e.g. Focal (can be done very shortly or not in changelog, but in details in the SRU template on the bug)

I have rebuilt the unpatched focal packages and published to https://launchpad.net/~philroche/+archive/ubuntu/google-guest-agent/ but this does not result in the troublesome `preinst` section like we had in jammy+

```
# Automatically added by dh_installsystemd/13.6ubuntu1
if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = upgrade ] && [ -d /run/systemd/system ] ; then
 deb-systemd-invoke stop 'google-shutdown-scripts.service' 'google-startup-scripts.service' >/dev/null || true
fi
# End automatically added section
```

Could this be as a result of `dh_installdeb/12.10ubuntu1` being used on focal vs `dh_installdeb/13.6ubuntu1` on jammy and the default changing between these versions?

> 3. add --no-enable or state in the bug in detail why you do not want/need it

Will do. We do want the services to be enabled on initial installation and to be started on instance start but they should not be restarted/stopped during the lifetime of the instance.

« Back to merge proposal