Merge ~philroche/ubuntu/+source/gce-compute-image-packages/+git/gce-compute-image-packages:trusty into ~ubuntu-dev/ubuntu/+source/gce-compute-image-packages/+git/gce-compute-image-packages:trusty

Proposed by Philip Roche
Status: Approved
Approved by: Mathieu Trudel-Lapierre
Approved revision: 9eec6a5d8187e50133441548d49980d574045820
Proposed branch: ~philroche/ubuntu/+source/gce-compute-image-packages/+git/gce-compute-image-packages:trusty
Merge into: ~ubuntu-dev/ubuntu/+source/gce-compute-image-packages/+git/gce-compute-image-packages:trusty
Diff against target: 0 lines
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email: mp+318097@code.launchpad.net

Description of the change

Fix where GCE shutdown scripts are run during shutdown when using Upstart (LP: #1667277)

This script should only run on shutdown and only when rsyslog is still running.

This fixes:
Shutdown scripts do not run on 1404 images with gce-compute-image-packages installed (LP: #1667277)

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

LGTM. My only issue is the version number which does not need to carry "ubuntu1", it should simply be bumped to 20160930-0ubuntu3~14.04.1.

review: Approve
9839ad6... by Mathieu Trudel-Lapierre

releasing package gce-compute-image-packages version 20160930-0ubuntu3~14.04.1

461e7fa... by Philip Roche

Updated version number to 20160930-0ubuntu3~14.04.1 instead of 20160930-0ubuntu3~14.04.0ubuntu1

Revision history for this message
Philip Roche (philroche) wrote :

Version now updated as per comments.

Unmerged commits

9839ad6... by Mathieu Trudel-Lapierre

releasing package gce-compute-image-packages version 20160930-0ubuntu3~14.04.1

461e7fa... by Philip Roche

Updated version number to 20160930-0ubuntu3~14.04.1 instead of 20160930-0ubuntu3~14.04.0ubuntu1

9eec6a5... by Philip Roche

Fix where GCE shutdown scripts are run during shutdown when using Upstart (LP: #1667277)

This script should only run on shutdown and only when rsyslog is still running.

This fixes:
Shutdown scripts do not run on 1404 images with gce-compute-image-packages installed (LP: #1667277)

Preview Diff

Empty

Subscribers

People subscribed via source and target branches