Merge ~philroche/ubuntu/+source/gce-compute-image-packages/+git/gce-compute-image-packages:yakkety into ~ubuntu-dev/ubuntu/+source/gce-compute-image-packages/+git/gce-compute-image-packages:yakkety

Proposed by Philip Roche
Status: Merged
Merged at revision: 3e7fe68e3470917ec4a695707f510a03d7382b0e
Proposed branch: ~philroche/ubuntu/+source/gce-compute-image-packages/+git/gce-compute-image-packages:yakkety
Merge into: ~ubuntu-dev/ubuntu/+source/gce-compute-image-packages/+git/gce-compute-image-packages:yakkety
Diff against target: 66 lines (+34/-1)
4 files modified
debian/changelog (+7/-0)
debian/patches/fix-startup-script-ordering.patch (+24/-0)
debian/patches/series (+1/-0)
google_compute_engine_init/systemd/google-startup-scripts.service (+2/-1)
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+311821@code.launchpad.net

Description of the change

GCE mirrors not in place before startup scripts are run (LP: #1436846)

Migrating the following startup scripts ordering from legacy gce-statup-scripts
package to gce-compute-image-packages

* GCE mirrors not in place before startup scripts are run (LP: #1436846)

Run google-startup-scripts.service after multi-user.target (LP: #1627436)

Migrating the following startup scripts ordering from legacy gce-statup-scripts
package to gce-compute-image-packages

* Run google-startup-scripts.service explicitly after multi-user.target
 to resolve ordering cycle between implicit Before multi-user.target
 and explicit After cloud-final.target. (LP: #1627436)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8062f79..5e4c81b 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+gce-compute-image-packages (20160930-0ubuntu3~16.10.0) yakkety; urgency=medium
7+
8+ * GCE mirrors not in place before startup scripts are run (LP: #1436846)
9+ * Run google-startup-scripts.service after multi-user.target (LP: #1627436)
10+
11+ -- Philip Roche <phil.roche@canonical.com> Fri, 25 Nov 2016 11:37:17 +0000
12+
13 gce-compute-image-packages (20160930-0ubuntu2) yakkety; urgency=medium
14
15 * Document all elements of the source package in debian/copyright.
16diff --git a/debian/patches/fix-startup-script-ordering.patch b/debian/patches/fix-startup-script-ordering.patch
17new file mode 100644
18index 0000000..1c65a25
19--- /dev/null
20+++ b/debian/patches/fix-startup-script-ordering.patch
21@@ -0,0 +1,24 @@
22+Description: Fix where GCE startup scripts are run during boot
23+ This fixes:
24+ * GCE mirrors not in place before startup scripts are run (LP: #1436846)
25+ * Run google-startup-scripts.service after multi-user.target (LP: #1627436)
26+
27+Author: Phil Roche <phil.roche@canonical.com>
28+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1436846
29+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1627436
30+Last-Update: 2016-11-23
31+
32+Index: gce-compute-image-packages-20160930/google_compute_engine_init/systemd/google-startup-scripts.service
33+===================================================================
34+--- gce-compute-image-packages-20160930.orig/google_compute_engine_init/systemd/google-startup-scripts.service
35++++ gce-compute-image-packages-20160930/google_compute_engine_init/systemd/google-startup-scripts.service
36+@@ -2,7 +2,8 @@
37+ Description=Google Compute Engine Startup Scripts
38+ After=local-fs.target network-online.target network.target rsyslog.service
39+ After=google-instance-setup.service google-network-setup.service
40+-Wants=local-fs.target network-online.target network.target
41++After=cloud-final.service multi-user.target
42++Wants=local-fs.target network-online.target network.target cloud-final.service
43+
44+ [Service]
45+ ExecStart=/usr/bin/google_metadata_script_runner --script-type startup
46diff --git a/debian/patches/series b/debian/patches/series
47new file mode 100644
48index 0000000..0787004
49--- /dev/null
50+++ b/debian/patches/series
51@@ -0,0 +1 @@
52+fix-startup-script-ordering.patch
53diff --git a/google_compute_engine_init/systemd/google-startup-scripts.service b/google_compute_engine_init/systemd/google-startup-scripts.service
54index 9c04d79..f4b27b8 100644
55--- a/google_compute_engine_init/systemd/google-startup-scripts.service
56+++ b/google_compute_engine_init/systemd/google-startup-scripts.service
57@@ -2,7 +2,8 @@
58 Description=Google Compute Engine Startup Scripts
59 After=local-fs.target network-online.target network.target rsyslog.service
60 After=google-instance-setup.service google-network-setup.service
61-Wants=local-fs.target network-online.target network.target
62+After=cloud-final.service multi-user.target
63+Wants=local-fs.target network-online.target network.target cloud-final.service
64
65 [Service]
66 ExecStart=/usr/bin/google_metadata_script_runner --script-type startup

Subscribers

People subscribed via source and target branches