Code review comment for lp:~philpem/ubuntu/utopic/ptouch-driver/ptouch-driver-fixup
Revision history for this message
| Phil Pemberton (philpem) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Thanks, Till!
The upstream developer is no longer maintaining the driver -- he says he no longer has time, which is fair enough. So I guess my Mercurial repository is the "latest" at the moment, and probably counts as a fork. I'll maintain it for my own use, but I don't intend to go any further with it. I certainly don't intend to, say, start buying P-touch printers and add support for them. I guess what I'm trying to say is, at the moment, it's good enough for me.
As for cloning the current Git repo - this version was done from the version in Bazaar, which may have had the existing patches already applied. Though that was after I'd run a build... perhaps I was misinterpreting what I saw. In any case, point noted. Committing patched source files did seem weird to me.
It'd be nice to see this fix make it into Utopic too (I guess that would be a backport?), though if that's not possible I'll probably take the package from Vivid and build it in a PPA for my own use.