Code review comment for lp:~philpem/ubuntu/utopic/ptouch-driver/ptouch-driver-fixup
Revision history for this message
| Till Kamppeter (till-kamppeter) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
More remarks:
- You need to update the debian/changelog file. It should mention what you actually have changed/fixed. It seems to be unchanged from your previous merge proposal.
- 80 % of your patch are changes in the .pc directory and so redundant. also every change in your new patches appears a second time as change in the upstream source code. Please first clone the original GIT of the current package, "quilt pop -a", remove or exclude .pc/ and then recommit, after that do your changes and commit under the same conditions (patches unapplied and no .pc/ directory), propose the resulting repo for merge then.