Ubuntu
ptouch-driver package

Code review comment for lp:~philpem/ubuntu/utopic/ptouch-driver/ptouch-driver-fixup

  1. Utopic (14.10)
  2. ptouch-driver-fixup
  3. Merge into utopic
Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

Generally it looks OK, but we need to consider the following:

1. GIT repositories of a package (or any changes on it) should be done always with the quilt patches not applied and without .pc directory, to avoid redundancies and to make it easy to modify a patch without needing to modify a whole bunch of other files along with it.

2. Such a lot of changes should go upstream and not kept as distro patches to the eternity. If the upstream maintainer has disappeared, I suggest that you overtake upstream maintainership.

« Back to merge proposal