Merge lp:~phill-ridout/openlp/bug1154059_2.0 into lp:openlp/2.0

[Phill]

Fixes #1154059 catching Unicode decode error.
Changed extension to *.* rather than just *

[Andreas Preikschat (googol-deactivatedaccount)]

I think this
27 + self.audio_extensions_list = [u'*']
28 + self.video_extensions_list = [u'*']

should rather be

self.audio_extensions_list = [u'*.*']
self.video_extensions_list = [u'*.*']

review: Needs Fixing

[Andreas Preikschat (googol-deactivatedaccount)]

Why do you assume that this is a python bug? Because Phonon.BackendCapabilities.availableMimeTypes() is related to Qt.

[Phill (phill-ridout)]

I though that about the *.*, but if you look in the filter combo box all
files is listed as just '*' so I went with that. Tell me if you still want
me to change this.

I came to the conclusion that it was a python bug as the traceback is
similar to: http://bugs.python.org/issue9291 see the linked (
https://bugs.launchpad.net/openlp/+bug/1154059) bug report.

<email address hidden> - Google Talk
phillr_97 - Skype

On 13 March 2013 17:02, Andreas Preikschat <email address hidden>wrote:

> Why do you assume that this is a python bug? Because
> Phonon.BackendCapabilities.availableMimeTypes() is related to Qt.
> --
>
> https://code.launchpad.net/~phill-ridout/openlp/bug1154059_2.0/+merge/153024
> You are the owner of lp:~phill-ridout/openlp/bug1154059_2.0.
>

[Raoul Snyman (raoul-snyman)]

One minor concern for me is how you're just discarding all the filters, but I do see the practical aspect of it, so I guess this is an acceptable approach.

review: Approve

[Andreas Preikschat (googol-deactivatedaccount)]

> One minor concern for me is how you're just discarding all the filters
Same here :)

review: Approve

=== modified file 'openlp/core/ui/media/phononplayer.py'
--- openlp/core/ui/media/phononplayer.py	2012-12-30 19:41:24 +0000
+++ openlp/core/ui/media/phononplayer.py	2013-03-14 22:19:21 +0000
@@ -69,13 +69,20 @@
         self.display_name = u'&Phonon'
         self.parent = parent
         self.additional_extensions = ADDITIONAL_EXT
-        mimetypes.init()
-        for mimetype in Phonon.BackendCapabilities.availableMimeTypes():
-            mimetype = unicode(mimetype)
-            if mimetype.startswith(u'audio/'):
-                self._addToList(self.audio_extensions_list, mimetype)
-            elif mimetype.startswith(u'video/'):
-                self._addToList(self.video_extensions_list, mimetype)
+        try:
+            mimetypes.init()
+            for mimetype in Phonon.BackendCapabilities.availableMimeTypes():
+                mimetype = unicode(mimetype)
+                if mimetype.startswith(u'audio/'):
+                    self._addToList(self.audio_extensions_list, mimetype)
+                elif mimetype.startswith(u'video/'):
+                    self._addToList(self.video_extensions_list, mimetype)
+        # Work around for http://bugs.python.org/issue9291
+        except UnicodeDecodeError:
+            log.exception(u'UnicodeDecodeError when trying to read mime types.'
+                'Setting extensions to all files')
+            self.audio_extensions_list = [u'*.*']
+            self.video_extensions_list = [u'*.*']
 
     def _addToList(self, list, mimetype):
         # Add all extensions which mimetypes provides us for supported types.