Code review comment for lp:~phill-ridout/openlp/bible_media_item_refactors

Revision history for this message
Phill (phill-ridout) wrote :

> On the select tab there is a stray button next to book, no icon and no obvious
> use.

That button is to sort books alphabetically. The resources need to be regened for the icon to show. I havn't included the compiled resources as to keep the diff clean! Will submit when this gets merged!

> Import bibles the select language could not find the language. Should it not
> default to the UI language but still ask?
>
> Seeing this on the console but not in trunk.
>
> QLayout: Attempting to add QLayout "" to QWidget "", which already has a
> layout
> QLayout: Attempting to add QLayout "" to QWidget "", which already has a
> layout
> QLayout: Attempting to add QLayout "" to QWidget "", which already has a
> layout
> QLayout: Attempting to add QLayout "" to QWidget "", which already has a
> layout
> QLayout: Attempting to add QLayout "" to QGroupBox "", which already has a
> layout

I'll take a look at these other issues.

« Back to merge proposal