OpenLP

Code review comment for lp:~phill-ridout/openlp/bible_media_item_refactors

  1. bible_media_item_refactors
  2. Merge into trunk
Revision history for this message
Tim Bentley (trb143) wrote :

On the select tab there is a stray button next to book, no icon and no obvious use.
Import bibles the select language could not find the language. Should it not default to the UI language but still ask?

Seeing this on the console but not in trunk.

QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout
QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout
QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout
QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout
QLayout: Attempting to add QLayout "" to QGroupBox "", which already has a layout

Looking alike a good clean up though.

review: Needs Fixing

« Back to merge proposal