Merge lp:~philip.scott/pantheon-photos/correct-key into lp:~pantheon-photos/pantheon-photos/trunk

Proposed by Felipe Escoto
Status: Rejected
Rejected by: Zisu Andrei
Proposed branch: lp:~philip.scott/pantheon-photos/correct-key
Merge into: lp:~pantheon-photos/pantheon-photos/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
data/pantheon-photos-viewer.desktop.in.in (+1/-1)
To merge this branch: bzr merge lp:~philip.scott/pantheon-photos/correct-key
Reviewer Review Type Date Requested Status
Zisu Andrei (community) Disapprove
Review via email: mp+301503@code.launchpad.net

Commit message

Use %u on the Exec key

Description of the change

%u is for a single file per command whether %U is for a list of files. This should make Photos keep it's current behavior when https://code.launchpad.net/~jeremywootten/pantheon-files/fix-multiple-file-launch is merged

To post a comment you must log in.
Revision history for this message
Zisu Andrei (matzipan) wrote :

With this branch, it still opens two instances.

review: Disapprove

Unmerged revisions

2978. By Felipe Escoto

use correct Exec key

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/pantheon-photos-viewer.desktop.in.in'
--- data/pantheon-photos-viewer.desktop.in.in 2016-01-14 12:35:35 +0000
+++ data/pantheon-photos-viewer.desktop.in.in 2016-07-29 15:19:15 +0000
@@ -1,7 +1,7 @@
1[Desktop Entry]1[Desktop Entry]
2_Name=Photo Viewer2_Name=Photo Viewer
3_GenericName=Photo Viewer3_GenericName=Photo Viewer
4Exec=@EXEC_NAME@ %U4Exec=@EXEC_NAME@ %u
5Icon=multimedia-photo-viewer5Icon=multimedia-photo-viewer
6_Keywords=install;uninstall;remove;catalogue;store;apps;updates;software;6_Keywords=install;uninstall;remove;catalogue;store;apps;updates;software;
7Terminal=false7Terminal=false

Subscribers

People subscribed via source and target branches