Code review comment for lp:~phanimahesh/friends/friends
Revision history for this message
| Robert Bruce Park (robru) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I had a quick look at the tests, and what I saw was that the mock data we
use in the testsuite doesn't have an underscore, so it's raising IndexError
because the call to split is ineffective. So you'll have to read the
traceback, and then follow the code path backwards to see where the mock
data is being defined (usually within each test it should declare some
dummy data). then you'll have to change the value to have the expected
number of underscores in it, with some arbitrary letters or numbers in
between. once you have that in place, then what'll happen is that the tests
will fail, because they expect the old timeline URL and not the new page
URL you're implementing. so just update the actual assertions to start
expecting the new URL, and that should pretty much do it.
On Mon, Jun 10, 2013 at 11:40 PM, J Phani Mahesh <
<email address hidden>> wrote:
> I'm not familiar with 'mock', which seems to be used for the unit tests.
> I've noticed that the tests fail, but was unable to identify what caused
> the failure. I'll give it a try once again.
> Do you have any tips that might help in finding the cause of failure?
>
> I've patched up my installation ( dog-fooding? :P) and it works great for
> me.
> --
> https:/
> You are reviewing the proposed merge of lp:~phanimahesh/friends/friends
> into lp:friends.
>