Merge lp:~phablet-team/ubuntu-system-settings/settings-listitems into lp:ubuntu-system-settings

Proposed by Jonas G. Drange
Status: Merged
Approved by: Ken VanDine
Approved revision: 1561
Merged at revision: 1676
Proposed branch: lp:~phablet-team/ubuntu-system-settings/settings-listitems
Merge into: lp:ubuntu-system-settings
Diff against target: 352 lines (+273/-11)
11 files modified
src/SystemSettings/CMakeLists.txt (+2/-0)
src/SystemSettings/ListItems/CMakeLists.txt (+13/-0)
src/SystemSettings/ListItems/Icon.qml (+33/-0)
src/SystemSettings/ListItems/IconProgression.qml (+30/-0)
src/SystemSettings/ListItems/SingleControl.qml (+34/-0)
src/SystemSettings/ListItems/SingleValue.qml (+30/-0)
src/SystemSettings/ListItems/SingleValueProgression.qml (+35/-0)
src/SystemSettings/ListItems/Standard.qml (+41/-0)
src/SystemSettings/ListItems/StandardProgression.qml (+29/-0)
src/SystemSettings/ListItems/qmldir (+9/-0)
src/SystemSettings/SettingsItemTitle.qml (+17/-11)
To merge this branch: bzr merge lp:~phablet-team/ubuntu-system-settings/settings-listitems
Reviewer Review Type Date Requested Status
Ken VanDine Approve
system-apps-ci-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+278322@code.launchpad.net

Commit message

new module SystemSettings.ListItems

To post a comment you must log in.
1559. By Jonas G. Drange

set the color of the dividers

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1560. By Ken VanDine

merged trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
1561. By Ken VanDine

merged trunk

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1561
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/25/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/784/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/784
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/728
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/728
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/728
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/720/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/720/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/720/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/720/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/720/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/720/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/720/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/720/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/720/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/25/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve
Revision history for this message
Alberto Mardegan (mardy) wrote :

Please let me know what I should do with https://code.launchpad.net/~mardy/ubuntu-system-settings/smoothed-1596529/+merge/298419

I think there will be some conflict with this branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/SystemSettings/CMakeLists.txt'
--- src/SystemSettings/CMakeLists.txt 2014-10-31 08:45:10 +0000
+++ src/SystemSettings/CMakeLists.txt 2016-06-29 14:34:55 +0000
@@ -6,3 +6,5 @@
6set(PLUG_DIR ${PLUGIN_QML_DIR}/SystemSettings)6set(PLUG_DIR ${PLUGIN_QML_DIR}/SystemSettings)
7install(FILES qmldir DESTINATION ${PLUG_DIR})7install(FILES qmldir DESTINATION ${PLUG_DIR})
8install(FILES ${QML_SOURCES} DESTINATION ${PLUG_DIR})8install(FILES ${QML_SOURCES} DESTINATION ${PLUG_DIR})
9
10add_subdirectory(ListItems)
911
=== added directory 'src/SystemSettings/ListItems'
=== added file 'src/SystemSettings/ListItems/CMakeLists.txt'
--- src/SystemSettings/ListItems/CMakeLists.txt 1970-01-01 00:00:00 +0000
+++ src/SystemSettings/ListItems/CMakeLists.txt 2016-06-29 14:34:55 +0000
@@ -0,0 +1,13 @@
1set(QML_SOURCES
2 Icon.qml
3 IconProgression.qml
4 SingleControl.qml
5 SingleValue.qml
6 SingleValueProgression.qml
7 Standard.qml
8 StandardProgression.qml
9)
10
11set(PLUG_DIR ${PLUGIN_QML_DIR}/SystemSettings/ListItems)
12install(FILES qmldir DESTINATION ${PLUG_DIR})
13install(FILES ${QML_SOURCES} DESTINATION ${PLUG_DIR})
014
=== added file 'src/SystemSettings/ListItems/Icon.qml'
--- src/SystemSettings/ListItems/Icon.qml 1970-01-01 00:00:00 +0000
+++ src/SystemSettings/ListItems/Icon.qml 2016-06-29 14:34:55 +0000
@@ -0,0 +1,33 @@
1/*
2 * This file is part of system-settings
3 *
4 * Copyright (C) 2015 Canonical Ltd.
5 *
6 * This program is free software: you can redistribute it and/or modify it
7 * under the terms of the GNU General Public License version 3, as published
8 * by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranties of
12 * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
13 * PURPOSE. See the GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License along
16 * with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19import QtQuick 2.4
20import Ubuntu.Components 1.3
21
22Standard {
23 id: base
24 property alias iconName: icon.name
25 property alias iconSource: icon.source
26
27 Icon {
28 id: icon
29 width: height
30 height: units.gu(2.5)
31 SlotsLayout.position: SlotsLayout.First
32 }
33}
034
=== added file 'src/SystemSettings/ListItems/IconProgression.qml'
--- src/SystemSettings/ListItems/IconProgression.qml 1970-01-01 00:00:00 +0000
+++ src/SystemSettings/ListItems/IconProgression.qml 2016-06-29 14:34:55 +0000
@@ -0,0 +1,30 @@
1/*
2 * This file is part of system-settings
3 *
4 * Copyright (C) 2015 Canonical Ltd.
5 *
6 * This program is free software: you can redistribute it and/or modify it
7 * under the terms of the GNU General Public License version 3, as published
8 * by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranties of
12 * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
13 * PURPOSE. See the GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License along
16 * with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19import QtQuick 2.4
20import "." as SettingsListItems
21import Ubuntu.Components 1.3
22
23SettingsListItems.Icon {
24 id: base
25 property alias progressionVisible: progression.visible
26
27 ProgressionSlot {
28 id: progression
29 }
30}
031
=== added file 'src/SystemSettings/ListItems/SingleControl.qml'
--- src/SystemSettings/ListItems/SingleControl.qml 1970-01-01 00:00:00 +0000
+++ src/SystemSettings/ListItems/SingleControl.qml 2016-06-29 14:34:55 +0000
@@ -0,0 +1,34 @@
1/*
2 * This file is part of system-settings
3 *
4 * Copyright (C) 2015 Canonical Ltd.
5 *
6 * This program is free software: you can redistribute it and/or modify it
7 * under the terms of the GNU General Public License version 3, as published
8 * by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranties of
12 * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
13 * PURPOSE. See the GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License along
16 * with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19import QtQuick 2.4
20import Ubuntu.Components 1.3
21
22ListItem {
23 id: root
24 default property alias slots: layoutItem.children
25 property alias layout: layoutItem
26 property bool showDivider: true
27
28 height: layoutItem.height + (divider.visible ? divider.height : 0)
29 divider.visible: showDivider
30
31 SlotsLayout {
32 id: layoutItem
33 }
34}
035
=== added file 'src/SystemSettings/ListItems/SingleValue.qml'
--- src/SystemSettings/ListItems/SingleValue.qml 1970-01-01 00:00:00 +0000
+++ src/SystemSettings/ListItems/SingleValue.qml 2016-06-29 14:34:55 +0000
@@ -0,0 +1,30 @@
1/*
2 * This file is part of system-settings
3 *
4 * Copyright (C) 2015 Canonical Ltd.
5 *
6 * This program is free software: you can redistribute it and/or modify it
7 * under the terms of the GNU General Public License version 3, as published
8 * by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranties of
12 * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
13 * PURPOSE. See the GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License along
16 * with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19import QtQuick 2.4
20import Ubuntu.Components 1.3
21
22Standard {
23 id: base
24 property alias value: value.text
25
26 Label {
27 id: value
28 horizontalAlignment: Text.AlignRight
29 }
30}
031
=== added file 'src/SystemSettings/ListItems/SingleValueProgression.qml'
--- src/SystemSettings/ListItems/SingleValueProgression.qml 1970-01-01 00:00:00 +0000
+++ src/SystemSettings/ListItems/SingleValueProgression.qml 2016-06-29 14:34:55 +0000
@@ -0,0 +1,35 @@
1/*
2 * This file is part of system-settings
3 *
4 * Copyright (C) 2015 Canonical Ltd.
5 *
6 * This program is free software: you can redistribute it and/or modify it
7 * under the terms of the GNU General Public License version 3, as published
8 * by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranties of
12 * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
13 * PURPOSE. See the GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License along
16 * with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19import QtQuick 2.4
20import Ubuntu.Components 1.3
21
22Standard {
23 id: base
24 property alias value: value.text
25 property alias progressionVisible: progression.visible
26
27 Label {
28 id: value
29 horizontalAlignment: Text.AlignRight
30 }
31
32 ProgressionSlot {
33 id: progression
34 }
35}
036
=== added file 'src/SystemSettings/ListItems/Standard.qml'
--- src/SystemSettings/ListItems/Standard.qml 1970-01-01 00:00:00 +0000
+++ src/SystemSettings/ListItems/Standard.qml 2016-06-29 14:34:55 +0000
@@ -0,0 +1,41 @@
1/*
2 * This file is part of system-settings
3 *
4 * Copyright (C) 2015 Canonical Ltd.
5 *
6 * This program is free software: you can redistribute it and/or modify it
7 * under the terms of the GNU General Public License version 3, as published
8 * by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranties of
12 * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
13 * PURPOSE. See the GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License along
16 * with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19import Ubuntu.Components 1.3
20
21ListItem {
22 id: root
23 default property alias slots: layoutItem.children
24 property alias layout: layoutItem
25 property string text
26 property bool showDivider: true
27 property bool highlightWhenPressed: true
28
29 height: layoutItem.height + (divider.visible ? divider.height : 0)
30 divider.visible: showDivider
31 divider.colorFrom: "#EEEEEE"
32 divider.colorTo: "#EEEEEE"
33 divider.height: units.dp(1)
34 highlightColor: highlightWhenPressed ? undefined : "transparent"
35
36 ListItemLayout {
37 id: layoutItem
38 title.text: root.text
39 title.opacity: enabled ? 1 : 0.5
40 }
41}
042
=== added file 'src/SystemSettings/ListItems/StandardProgression.qml'
--- src/SystemSettings/ListItems/StandardProgression.qml 1970-01-01 00:00:00 +0000
+++ src/SystemSettings/ListItems/StandardProgression.qml 2016-06-29 14:34:55 +0000
@@ -0,0 +1,29 @@
1/*
2 * This file is part of system-settings
3 *
4 * Copyright (C) 2015 Canonical Ltd.
5 *
6 * This program is free software: you can redistribute it and/or modify it
7 * under the terms of the GNU General Public License version 3, as published
8 * by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranties of
12 * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
13 * PURPOSE. See the GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License along
16 * with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19import QtQuick 2.4
20import Ubuntu.Components 1.3
21
22Standard {
23 id: base
24 property alias progressionVisible: progression.visible
25
26 ProgressionSlot {
27 id: progression
28 }
29}
030
=== added file 'src/SystemSettings/ListItems/qmldir'
--- src/SystemSettings/ListItems/qmldir 1970-01-01 00:00:00 +0000
+++ src/SystemSettings/ListItems/qmldir 2016-06-29 14:34:55 +0000
@@ -0,0 +1,9 @@
1module SystemSettings.ListItems
2
3Icon 1.0 Icon.qml
4IconProgression 1.0 IconProgression.qml
5SingleControl 1.0 SingleControl.qml
6SingleValue 1.0 SingleValue.qml
7SingleValueProgression 1.0 SingleValueProgression.qml
8Standard 1.0 Standard.qml
9StandardProgression 1.0 StandardProgression.qml
010
=== modified file 'src/SystemSettings/SettingsItemTitle.qml'
--- src/SystemSettings/SettingsItemTitle.qml 2015-08-10 13:31:45 +0000
+++ src/SystemSettings/SettingsItemTitle.qml 2016-06-29 14:34:55 +0000
@@ -18,21 +18,27 @@
1818
19import QtQuick 2.419import QtQuick 2.4
20import Ubuntu.Components 1.320import Ubuntu.Components 1.3
21import Ubuntu.Components.ListItems 1.3 as ListItem21
2222Item {
23ListItem.Standard {23 property alias text: label.text
24 id: itemEmpty24 anchors {
25 property string text25 left: parent.left
26 right: parent.right
27 }
28 height: units.gu(6)
29
26 Label {30 Label {
31 id: label
27 anchors {32 anchors {
33 top: parent.top
34 topMargin: units.gu(3)
35 right: parent.right
36 rightMargin: units.gu(2)
37 bottom: parent.bottom
28 left: parent.left38 left: parent.left
29 leftMargin: units.gu(2)39 leftMargin: units.gu(2)
30 right: parent.right
31 rightMargin: units.gu(2)
32 top: parent.top
33 topMargin: units.gu(3)
34 }40 }
35 text: itemEmpty.text41 fontSize: "small"
42 opacity: 0.75
36 }43 }
37 highlightWhenPressed: false
38}44}

Subscribers

People subscribed via source and target branches