Code review comment for lp:~phablet-team/ubuntu-system-settings/permission-page-url

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Yay for fixing this bug. However, URLs of the form settings:///system/security-privacy?service=camera are needlessly brittle. It's generally a bad idea for URLs to contain subjective categorization. This applies to a System Settings screen for the same same reason that it applies to a Web page (e.g. bug bug 1516732): links to it shouldn't break if the categorization changes.

Camera permissions won't necessarily be in "Security & Privacy" forever. (For example, we might give them their own top-level category, or combine them with Online Accounts.) And even if they are, "Security & Privacy" won't necessarily be in "System" forever. If either of those things changes, apps that send you to this screen should still send you to this screen, because the URL should not have changed.

So I suggest that it should not be "settings:///system/security-privacy?service=camera", it should be something like "settings:///permissions?service=camera".

« Back to merge proposal