Merge lp:~phablet-team/telephony-service/fix-hardcoded-paths into lp:telephony-service

Proposed by Roberto Mier Escandon
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 1215
Merged at revision: 1221
Proposed branch: lp:~phablet-team/telephony-service/fix-hardcoded-paths
Merge into: lp:telephony-service
Diff against target: 112 lines (+86/-2)
2 files modified
config.h.in (+4/-2)
snapcraft.yaml (+82/-0)
To merge this branch: bzr merge lp:~phablet-team/telephony-service/fix-hardcoded-paths
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
system-apps-ci-bot continuous-integration Approve
Review via email: mp+311716@code.launchpad.net

Commit message

prefixes snap env var value to paths in case service is into a snap package

Description of the change

prefixes snap env var value to paths in case service is into a snap package

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1213
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/87/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/2055/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2058
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1888
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1888/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1888/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1888
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1888/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1888
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1888/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1888
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1888/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1888
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1888/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1888
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1888/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1888
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1888/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1888
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1888/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/87/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1214
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/88/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/2057/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2060
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1890
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1890/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1890/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1890
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1890
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1890
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1890
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1890
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1890
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1890/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1890/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/88/rebuild

review: Needs Fixing (continuous-integration)
1215. By Roberto Mier Escandon

corrected bad var reference

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1215
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/91/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2066
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/505
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2069
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1899
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1899/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1899
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1899/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1899
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1899/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1899
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1899/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1899
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1899/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1899
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1899/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1899
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1899/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1899
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1899/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1899
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1899/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/91/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Works fine. Tested telephony apps with ofono emulator and they are able to send messages and make calls.

review: Approve
1216. By Roberto Mier Escandon

set explicitly the architectures to build

1217. By Roberto Mier Escandon

rolledback to any architecture build

1218. By Renato Araujo Oliveira Filho

Trunk merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.h.in'
--- config.h.in 2015-08-26 08:19:56 +0000
+++ config.h.in 2016-12-05 15:15:21 +0000
@@ -37,7 +37,9 @@
37}37}
3838
39inline QString telephonyServiceDir() {39inline QString telephonyServiceDir() {
40 if (isRunningInstalled()) {40 if (qEnvironmentVariableIsSet("SNAP")) {
41 return QString("%1/@CMAKE_INSTALL_PREFIX@/@TELEPHONY_SERVICE_DIR@/").arg(QString(qgetenv("SNAP")));
42 } else if (isRunningInstalled()) {
41 return QString("@CMAKE_INSTALL_PREFIX@/@TELEPHONY_SERVICE_DIR@/");43 return QString("@CMAKE_INSTALL_PREFIX@/@TELEPHONY_SERVICE_DIR@/");
42 } else {44 } else {
43 return QString("@CMAKE_SOURCE_DIR@/");45 return QString("@CMAKE_SOURCE_DIR@/");
@@ -45,7 +47,7 @@
45}47}
4648
47inline QString ubuntuPhonePluginPath() {49inline QString ubuntuPhonePluginPath() {
48 if (isRunningInstalled()) {50 if (isRunningInstalled() || qEnvironmentVariableIsSet("SNAP")) {
49 return QString::null;51 return QString::null;
50 } else {52 } else {
51 return QString("@CMAKE_SOURCE_DIR@/");53 return QString("@CMAKE_SOURCE_DIR@/");
5254
=== added directory 'snap'
=== added directory 'snap/ubuntu-app-platform'
=== added file 'snapcraft.yaml'
--- snapcraft.yaml 1970-01-01 00:00:00 +0000
+++ snapcraft.yaml 2016-12-05 15:15:21 +0000
@@ -0,0 +1,82 @@
1name: telephony-service
2version: 0.1
3summary: Telephony service components for Ubuntu - backend
4description:
5 Telephony service components for Ubuntu.
6 .
7 This package contains the backend components providing the telephony
8 features such as calling and texting.
9confinement: devmode
10grade: devel
11
12apps:
13 indicator:
14 command: desktop-launch $SNAP/usr/bin/telephony-service-indicator
15 plugs: [platform]
16
17 handler:
18 command: desktop-launch $SNAP/usr/bin/telephony-service-handler
19 plugs: [platform]
20
21 approver:
22 command: desktop-launch $SNAP/usr/bin/telephony-service-approver
23 plugs: [platform]
24
25plugs:
26 platform:
27 interface: content
28 content: ubuntu-app-platform1
29 target: ubuntu-app-platform
30 default-provider: ubuntu-app-platform
31
32#slots:
33# telephony:
34# interface: telephony
35
36parts:
37 telephony-service:
38 plugin: cmake
39 configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCMAKE_CROSSCOMPILING=On]
40 source: .
41 build-packages:
42 - cmake
43 - dh-translations
44 - dconf-cli
45 - gnome-keyring
46 - gsettings-ubuntu-schemas
47 - libhistoryservice-dev
48 - libicu-dev
49 - libmessaging-menu-dev
50 - libnotify-dev
51 - libphonenumber-dev
52 - libtelepathy-qt5-dev
53 - libubuntu-application-api-dev
54 - libprotobuf-dev
55 - pkg-config
56 - qt5-default
57 - qtbase5-dev
58 - qtdeclarative5-dev
59 - qtdeclarative5-dev-tools
60 - qtfeedback5-dev
61 - qtdeclarative5-ubuntu-ui-toolkit-plugin
62 - qtmultimedia5-dev
63 - qtpim5-dev
64 - libusermetricsinput1-dev
65 - telepathy-mission-control-5
66 - upstart
67 stage-packages:
68 - accountsservice-ubuntu-touch-schemas
69 - gsettings-ubuntu-schemas
70 - history-service
71 - libnotify4
72 - telepathy-mission-control-5
73 - ubuntu-sounds
74 - tone-generator
75 - libusermetricsinput1
76 - dconf-cli
77 after: [desktop-ubuntu-app-platform]
78
79 environment:
80 source: snap
81 plugin: dump
82

Subscribers

People subscribed via source and target branches

to all changes: