Code review comment for lp:~phablet-team/network-manager/lp1435776

I have tried the patch in arale vivid image #35, but the bug did not go away.

To reproduce the issue, I use a SIM that does not need user or password. I change the "gprs" file introducing a user, but without password. I check that the operator still activates the context using the activate-context script. Then I checked that current NM is not able to activate the context. Finally, using the patched NM I still see the issue. The only difference I have noted is that apparently NM is trying only once to activate the context. The trace I see are (the old NM produced similar ones, but twice):

May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <info> Auto-activating connection '/214050030479893/context1'.
May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <info> Activation (ril_0) starting connection '/214050030479893/context1'
May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <info> Activation (ril_0) Stage 1 of 5 (Device Prepare) scheduled...
May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <info> Activation (ril_0) Stage 1 of 5 (Device Prepare) started...
May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <info> (ril_0): device state change: disconnected -> prepare (reason 'none') [30 40 0]
May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <info> (ril_0): device state change: prepare -> failed (reason 'no-secrets') [40 120 7]
May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <warn> Activation (ril_0) failed for connection '/214050030479893/context1'
May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <info> Activation (ril_0) Stage 1 of 5 (Device Prepare) complete.
May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <info> (ril_0): device state change: failed -> disconnected (reason 'none') [120 30 0]
May 11 13:08:31 ubuntu-phablet NetworkManager[1206]: <info> (ril_0): deactivating device (reason 'none') [0]