Mir

Code review comment for lp:~phablet-team/mir/track-plug-state

Revision history for this message
Kevin DuBois (kdub) wrote :

in my reading of hwc spec, we're specifically guaranteed that checking the display config of a device is allowed (<groan>)
https://android.googlesource.com/platform/hardware/libhardware/+/master/include/hardware/hwcomposer.h#492

If it is a problem on this device though, this doesn't look bad, although I might follow up to solve the problem at a higher level and to add tests (this class is just supposed to be a wrapper)

review: Approve

« Back to merge proposal