Code review comment for lp:~phablet-team/media-hub/video-support

Revision history for this message
Ricardo Mendoza (ricmm) wrote :

91 +include_directories(${PC_GSTREAMER_1_0_INCLUDE_DIRS} /usr/include/hybris)
99 + -lmedia

libmedia-dev ships a pkg config file for this

495 + std::cout << "IGBPWrapperHybris: " << igbp << std::endl;
496 + SurfaceTextureClientHybris stc = surface_texture_client_create_by_igbp(igbp);
497 + std::cout << "SurfaceTextureClientHybris: " << stc << std::endl;

Those couts are probably not needed anymore, even if we are keeping a good chunk of debug info

863 + seeked_to.connect([this](std::uint64_t value)
864 + {
865 + std::cout << "value: " << value << std::endl;
866 + //dbus.seeked_to->emit(value);
867 + });

Lets try and get rid of those ^

1166 + throw std::runtime_error("Problem switching to next track on remote object");

Odd error message from context

review: Needs Fixing

« Back to merge proposal