Merge lp:~phablet-team/media-hub/fix-sd-card-access into lp:media-hub

[Ricardo Salveti]

add /media to allowed playback paths for SD card support

add /media to allowed playback paths for SD card support

[Oliver Grawert (ogra)]

untested yet, please wait with approving til the code was verified.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:48
http://jenkins.qa.ubuntu.com/job/media-hub-ci/81/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-armhf-ci/22
        deb: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-armhf-ci/22/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-i386-ci/21

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/81/rebuild

review: Approve (continuous-integration)

[Oliver Grawert (ogra)]

test built, works fine

[Sergio Schvezov (sergiusens)]

Ideally I'd keep the app check in here and move the path check to an apparmor profile (probably in lxc-android-config) to not affect the desktop for now (or even as part of this if considered appropriate).

review: Approve

[Ricardo Salveti (rsalveti)]

Tried but I still can't successfully play the mp3 files in my sdcard. I can't see them, open them but only a few will play, and also not able to seek.

Not sure if there is something else that also needs fixing.

review: Needs Information

[Sergio Schvezov (sergiusens)]

> Tried but I still can't successfully play the mp3 files in my sdcard. I can't
> see them, open them but only a few will play, and also not able to seek.

I have this even without sdcard! Mind double checking? If you can't see them, restart mediascanner, this still needs fixing :-)

> Not sure if there is something else that also needs fixing.

Check the media scanner and media scanner activity in your session logs

[Ricardo Salveti (rsalveti)]

Indeed, quite interesting, I don't have any issues with one album I have, but can easily have the issues described above with a different set of mp3s.

Something else is indeed broken, but this MR is fine, let's land it.

review: Approve

[Ricardo Salveti (rsalveti)]

review: Approve

[Sergio Schvezov (sergiusens)]

review: Approve

[Oliver Grawert (ogra)]

any UTF-8 in titles (or artitst) ?

=== modified file 'src/core/media/player_skeleton.cpp'
--- src/core/media/player_skeleton.cpp	2014-05-21 08:25:44 +0000
+++ src/core/media/player_skeleton.cpp	2014-08-08 02:26:58 +0000
@@ -202,7 +202,8 @@
         // then remove the explicit whitelist of the music-app, and gallery-app
         else if ((pkgname == "com.ubuntu.music" || pkgname == "com.ubuntu.gallery") &&
                 (uri.find(std::string("Music/")) != std::string::npos
-                || uri.find(std::string("Videos/")) != std::string::npos))
+                || uri.find(std::string("Videos/")) != std::string::npos
+                || uri.find(std::string("/media")) != std::string::npos))
         {
             std::cout << "Client can access content in ~/Music or ~/Videos" << std::endl;
             return true;