Merge lp:~ogra/media-hub/fix-sd-card-access into lp:media-hub

Proposed by Oliver Grawert
Status: Superseded
Proposed branch: lp:~ogra/media-hub/fix-sd-card-access
Merge into: lp:media-hub
Diff against target: 13 lines (+2/-1)
1 file modified
src/core/media/player_skeleton.cpp (+2/-1)
To merge this branch: bzr merge lp:~ogra/media-hub/fix-sd-card-access
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
Sergio Schvezov Approve
PS Jenkins bot continuous-integration Approve
Jamie Strandboge paths mediated by apparmor Pending
Review via email: mp+229947@code.launchpad.net

This proposal has been superseded by a proposal from 2014-08-08.

Commit message

add /media to allowed playback paths for SD card support

Description of the change

add /media to allowed playback paths for SD card support

To post a comment you must log in.
Revision history for this message
Oliver Grawert (ogra) wrote :

untested yet, please wait with approving til the code was verified.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Oliver Grawert (ogra) wrote :

test built, works fine

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Ideally I'd keep the app check in here and move the path check to an apparmor profile (probably in lxc-android-config) to not affect the desktop for now (or even as part of this if considered appropriate).

review: Approve
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Tried but I still can't successfully play the mp3 files in my sdcard. I can't see them, open them but only a few will play, and also not able to seek.

Not sure if there is something else that also needs fixing.

review: Needs Information
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

> Tried but I still can't successfully play the mp3 files in my sdcard. I can't
> see them, open them but only a few will play, and also not able to seek.

I have this even without sdcard! Mind double checking? If you can't see them, restart mediascanner, this still needs fixing :-)

> Not sure if there is something else that also needs fixing.

Check the media scanner and media scanner activity in your session logs

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Indeed, quite interesting, I don't have any issues with one album I have, but can easily have the issues described above with a different set of mp3s.

Something else is indeed broken, but this MR is fine, let's land it.

review: Approve
Revision history for this message
Oliver Grawert (ogra) wrote :

any UTF-8 in titles (or artitst) ?

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/core/media/player_skeleton.cpp'
2--- src/core/media/player_skeleton.cpp 2014-05-21 08:25:44 +0000
3+++ src/core/media/player_skeleton.cpp 2014-08-07 14:32:06 +0000
4@@ -202,7 +202,8 @@
5 // then remove the explicit whitelist of the music-app, and gallery-app
6 else if ((pkgname == "com.ubuntu.music" || pkgname == "com.ubuntu.gallery") &&
7 (uri.find(std::string("Music/")) != std::string::npos
8- || uri.find(std::string("Videos/")) != std::string::npos))
9+ || uri.find(std::string("Videos/")) != std::string::npos
10+ || uri.find(std::string("/media")) != std::string::npos))
11 {
12 std::cout << "Client can access content in ~/Music or ~/Videos" << std::endl;
13 return true;

Subscribers

People subscribed via source and target branches