Code review comment for lp:~phablet-team/media-hub/add-logger
Revision history for this message
| Konrad Zapałowicz (kzapalowicz) wrote | # |
review:
Needs Fixing
(code)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Not many issues compared to the length of the diff and frankly I'm mostly concerned about the own noncopyable class.
There is also one thing which is not bad however I would like to highlight it. I did not like the need to create stringstream in so many cases to log a line as basically this is repeating.