Merge lp:~phablet-team/camera-app/disk-space-monitor into lp:camera-app

Proposed by Florian Boucault
Status: Merged
Approved by: Bill Filler
Approved revision: 494
Merged at revision: 483
Proposed branch: lp:~phablet-team/camera-app/disk-space-monitor
Merge into: lp:camera-app
Diff against target: 229 lines (+50/-125)
5 files modified
CameraApp/qstorageinfo.cpp (+11/-31)
CameraApp/qstorageinfo.h (+11/-31)
CameraApp/qstorageinfo_p.h (+12/-31)
CameraApp/qstorageinfo_unix.cpp (+11/-31)
camera-apparmor.json (+5/-1)
To merge this branch: bzr merge lp:~phablet-team/camera-app/disk-space-monitor
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+247528@code.launchpad.net

Commit message

warn the user of low disk space while recording or taking a picture

Description of the change

Warn the user when low free space remains.
When critically low free space remains:
- stop any ongoing video recording
- prevent the user from taking pictures and shooting videos

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
492. By Ugo Riboni

Fix an incorrect stub in the unit tests

493. By Ugo Riboni

Merge upstream changes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

The mako test in the above ci results was aborted due to a mako device with a bad image. The CI run has been re-triggered and will run on a different device.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
494. By Ugo Riboni

Add apparmor permissions so we can read the system files we need to query storage information

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
495. By Ugo Riboni

Change the license headers from QT stuff to plain GPL3, as we are allowed to do that and licensecheck understands it

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CameraApp/qstorageinfo.cpp'
--- CameraApp/qstorageinfo.cpp 2015-01-22 16:15:08 +0000
+++ CameraApp/qstorageinfo.cpp 2015-01-27 14:34:46 +0000
@@ -5,37 +5,17 @@
5**5**
6** This file is part of the QtCore module of the Qt Toolkit.6** This file is part of the QtCore module of the Qt Toolkit.
7**7**
8** $QT_BEGIN_LICENSE:LGPL$8** This program is free software; you can redistribute it and/or modify
9** Commercial License Usage9** it under the terms of the GNU General Public License as published by
10** Licensees holding valid commercial Qt licenses may use this file in10** the Free Software Foundation; version 3.
11** accordance with the commercial license agreement provided with the11**
12** Software or, alternatively, in accordance with the terms contained in12** This program is distributed in the hope that it will be useful,
13** a written agreement between you and Digia. For licensing terms and13** but WITHOUT ANY WARRANTY; without even the implied warranty of
14** conditions see http://qt.digia.com/licensing. For further information14** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15** use the contact form at http://qt.digia.com/contact-us.15** GNU General Public License for more details.
16**16**
17** GNU Lesser General Public License Usage17** You should have received a copy of the GNU General Public License
18** Alternatively, this file may be used under the terms of the GNU Lesser18** along with this program. If not, see <http://www.gnu.org/licenses/>.
19** General Public License version 2.1 as published by the Free Software
20** Foundation and appearing in the file LICENSE.LGPL included in the
21** packaging of this file. Please review the following information to
22** ensure the GNU Lesser General Public License version 2.1 requirements
23** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
24**
25** In addition, as a special exception, Digia gives you certain additional
26** rights. These rights are described in the Digia Qt LGPL Exception
27** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
28**
29** GNU General Public License Usage
30** Alternatively, this file may be used under the terms of the GNU
31** General Public License version 3.0 as published by the Free Software
32** Foundation and appearing in the file LICENSE.GPL included in the
33** packaging of this file. Please review the following information to
34** ensure the GNU General Public License version 3.0 requirements will be
35** met: http://www.gnu.org/copyleft/gpl.html.
36**
37**
38** $QT_END_LICENSE$
39**19**
40****************************************************************************/20****************************************************************************/
4121
4222
=== modified file 'CameraApp/qstorageinfo.h'
--- CameraApp/qstorageinfo.h 2015-01-22 16:15:08 +0000
+++ CameraApp/qstorageinfo.h 2015-01-27 14:34:46 +0000
@@ -5,37 +5,17 @@
5**5**
6** This file is part of the QtCore module of the Qt Toolkit.6** This file is part of the QtCore module of the Qt Toolkit.
7**7**
8** $QT_BEGIN_LICENSE:LGPL$8** This program is free software; you can redistribute it and/or modify
9** Commercial License Usage9** it under the terms of the GNU General Public License as published by
10** Licensees holding valid commercial Qt licenses may use this file in10** the Free Software Foundation; version 3.
11** accordance with the commercial license agreement provided with the11**
12** Software or, alternatively, in accordance with the terms contained in12** This program is distributed in the hope that it will be useful,
13** a written agreement between you and Digia. For licensing terms and13** but WITHOUT ANY WARRANTY; without even the implied warranty of
14** conditions see http://qt.digia.com/licensing. For further information14** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15** use the contact form at http://qt.digia.com/contact-us.15** GNU General Public License for more details.
16**16**
17** GNU Lesser General Public License Usage17** You should have received a copy of the GNU General Public License
18** Alternatively, this file may be used under the terms of the GNU Lesser18** along with this program. If not, see <http://www.gnu.org/licenses/>.
19** General Public License version 2.1 as published by the Free Software
20** Foundation and appearing in the file LICENSE.LGPL included in the
21** packaging of this file. Please review the following information to
22** ensure the GNU Lesser General Public License version 2.1 requirements
23** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
24**
25** In addition, as a special exception, Digia gives you certain additional
26** rights. These rights are described in the Digia Qt LGPL Exception
27** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
28**
29** GNU General Public License Usage
30** Alternatively, this file may be used under the terms of the GNU
31** General Public License version 3.0 as published by the Free Software
32** Foundation and appearing in the file LICENSE.GPL included in the
33** packaging of this file. Please review the following information to
34** ensure the GNU General Public License version 3.0 requirements will be
35** met: http://www.gnu.org/copyleft/gpl.html.
36**
37**
38** $QT_END_LICENSE$
39**19**
40****************************************************************************/20****************************************************************************/
4121
4222
=== modified file 'CameraApp/qstorageinfo_p.h'
--- CameraApp/qstorageinfo_p.h 2015-01-22 16:15:08 +0000
+++ CameraApp/qstorageinfo_p.h 2015-01-27 14:34:46 +0000
@@ -3,39 +3,20 @@
3** Copyright (C) 2014 Ivan Komissarov <ABBAPOH@gmail.com>3** Copyright (C) 2014 Ivan Komissarov <ABBAPOH@gmail.com>
4** Contact: http://www.qt-project.org/legal4** Contact: http://www.qt-project.org/legal
5**5**
6**
6** This file is part of the QtCore module of the Qt Toolkit.7** This file is part of the QtCore module of the Qt Toolkit.
7**8**
8** $QT_BEGIN_LICENSE:LGPL$9** This program is free software; you can redistribute it and/or modify
9** Commercial License Usage10** it under the terms of the GNU General Public License as published by
10** Licensees holding valid commercial Qt licenses may use this file in11** the Free Software Foundation; version 3.
11** accordance with the commercial license agreement provided with the12**
12** Software or, alternatively, in accordance with the terms contained in13** This program is distributed in the hope that it will be useful,
13** a written agreement between you and Digia. For licensing terms and14** but WITHOUT ANY WARRANTY; without even the implied warranty of
14** conditions see http://qt.digia.com/licensing. For further information15** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15** use the contact form at http://qt.digia.com/contact-us.16** GNU General Public License for more details.
16**17**
17** GNU Lesser General Public License Usage18** You should have received a copy of the GNU General Public License
18** Alternatively, this file may be used under the terms of the GNU Lesser19** along with this program. If not, see <http://www.gnu.org/licenses/>.
19** General Public License version 2.1 as published by the Free Software
20** Foundation and appearing in the file LICENSE.LGPL included in the
21** packaging of this file. Please review the following information to
22** ensure the GNU Lesser General Public License version 2.1 requirements
23** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
24**
25** In addition, as a special exception, Digia gives you certain additional
26** rights. These rights are described in the Digia Qt LGPL Exception
27** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
28**
29** GNU General Public License Usage
30** Alternatively, this file may be used under the terms of the GNU
31** General Public License version 3.0 as published by the Free Software
32** Foundation and appearing in the file LICENSE.GPL included in the
33** packaging of this file. Please review the following information to
34** ensure the GNU General Public License version 3.0 requirements will be
35** met: http://www.gnu.org/copyleft/gpl.html.
36**
37**
38** $QT_END_LICENSE$
39**20**
40****************************************************************************/21****************************************************************************/
4122
4223
=== modified file 'CameraApp/qstorageinfo_unix.cpp'
--- CameraApp/qstorageinfo_unix.cpp 2015-01-22 16:15:08 +0000
+++ CameraApp/qstorageinfo_unix.cpp 2015-01-27 14:34:46 +0000
@@ -5,37 +5,17 @@
5**5**
6** This file is part of the QtCore module of the Qt Toolkit.6** This file is part of the QtCore module of the Qt Toolkit.
7**7**
8** $QT_BEGIN_LICENSE:LGPL$8** This program is free software; you can redistribute it and/or modify
9** Commercial License Usage9** it under the terms of the GNU General Public License as published by
10** Licensees holding valid commercial Qt licenses may use this file in10** the Free Software Foundation; version 3.
11** accordance with the commercial license agreement provided with the11**
12** Software or, alternatively, in accordance with the terms contained in12** This program is distributed in the hope that it will be useful,
13** a written agreement between you and Digia. For licensing terms and13** but WITHOUT ANY WARRANTY; without even the implied warranty of
14** conditions see http://qt.digia.com/licensing. For further information14** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15** use the contact form at http://qt.digia.com/contact-us.15** GNU General Public License for more details.
16**16**
17** GNU Lesser General Public License Usage17** You should have received a copy of the GNU General Public License
18** Alternatively, this file may be used under the terms of the GNU Lesser18** along with this program. If not, see <http://www.gnu.org/licenses/>.
19** General Public License version 2.1 as published by the Free Software
20** Foundation and appearing in the file LICENSE.LGPL included in the
21** packaging of this file. Please review the following information to
22** ensure the GNU Lesser General Public License version 2.1 requirements
23** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
24**
25** In addition, as a special exception, Digia gives you certain additional
26** rights. These rights are described in the Digia Qt LGPL Exception
27** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
28**
29** GNU General Public License Usage
30** Alternatively, this file may be used under the terms of the GNU
31** General Public License version 3.0 as published by the Free Software
32** Foundation and appearing in the file LICENSE.GPL included in the
33** packaging of this file. Please review the following information to
34** ensure the GNU General Public License version 3.0 requirements will be
35** met: http://www.gnu.org/copyleft/gpl.html.
36**
37**
38** $QT_END_LICENSE$
39**19**
40****************************************************************************/20****************************************************************************/
4121
4222
=== modified file 'camera-apparmor.json'
--- camera-apparmor.json 2014-12-02 12:59:18 +0000
+++ camera-apparmor.json 2015-01-27 14:34:46 +0000
@@ -10,5 +10,9 @@
10 "content_exchange_source",10 "content_exchange_source",
11 "location"11 "location"
12 ],12 ],
13 "policy_version": 1.213 "policy_version": 1.2,
14 "read_path": [
15 "@{PROC}/*/mounts",
16 "/dev/disk/by-label/"
17 ]
14}18}

Subscribers

People subscribed via source and target branches