Merge lp:~pguimaraes/charms/trusty/memcached/trunk into lp:charms/trusty/memcached

Proposed by Pedro Guimarães
Status: Needs review
Proposed branch: lp:~pguimaraes/charms/trusty/memcached/trunk
Merge into: lp:charms/trusty/memcached
Diff against target: 26 lines (+9/-1)
1 file modified
hooks/memcached_hooks.py (+9/-1)
To merge this branch: bzr merge lp:~pguimaraes/charms/trusty/memcached/trunk
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+356187@code.launchpad.net

Commit message

Adding public-address to grant_access on firewall policy
fixes: lp:1796269

To post a comment you must log in.

Unmerged revisions

79. By Pedro Guimarães

Adding public-address to grant_access on firewall policy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/memcached_hooks.py'
--- hooks/memcached_hooks.py 2017-05-05 10:30:16 +0000
+++ hooks/memcached_hooks.py 2018-10-05 11:51:42 +0000
@@ -168,13 +168,21 @@
168 log('Granting memcached access to {}'.format(addr), level='INFO')168 log('Granting memcached access to {}'.format(addr), level='INFO')
169 grant_access(addr)169 grant_access(addr)
170170
171 public_addr = relation_get('public-address')
172 if public_addr:
173 log('Granting mem cached access to public address {}'.format(public_addr), level='INFO')
174 grant_access(public_addr)
175
171176
172@hooks.hook('cache-relation-departed')177@hooks.hook('cache-relation-departed')
173def cache_relation_departed():178def cache_relation_departed():
174 addr = relation_get('private-address')179 addr = relation_get('private-address')
175 log('Revoking memcached access to {}'.format(addr))180 log('Revoking memcached access to {}'.format(addr))
176 revoke_access(addr)181 revoke_access(addr)
177182 public_addr = relation_get('public-address')
183 if public_addr:
184 log('Revoking memcached access to public address {}'.format(public_addr))
185 revoke_access(public_addr)
178186
179@hooks.hook('config-changed')187@hooks.hook('config-changed')
180@restart_on_change(RESTART_MAP)188@restart_on_change(RESTART_MAP)

Subscribers

People subscribed via source and target branches