Code review comment for ~pguimaraes/charm-rsyslog-forwarder-ha/+git/rsyslog-forwarder-ha-charm:master

> Hi thanks for this patch. There are multiple things being fixed/added here so
> typically it should be split into separate patches but since the cert change
> is pretty isolated i thinks its ok land in one. I would however like to hear
> more about what testing has been done specifically for Bionic since iiuc the
> rsyslog and rsyslog-forwarder-ha have never has formal Bionic testing. Also I
> see that you have added rsyslog-gnutls as a dep but on my Xenial system that
> is not installed by default.

Yes, there were multiple small fixes but my main targets are Bionic and TLS support. So, the rsyslog-gnutls does not come installed by default and it is setup during install hook (line 198/199 on hooks/hooks.py). That package enables "gtls" option on rsyslog configs.
To test everything, I've strictly followed this step-by-step: https://www.rsyslog.com/doc/master/tutorials/tls.html?highlight=defaultnetstreamdrivercafile and used logger to send messages from client-side.
The main bundle for this test was: https://pastebin.canonical.com/p/Ksf5Jx9D8G/