Code review comment for ~pfsmorigo/ubuntu-cve-tracker:cve.vim_add_functions

Revision history for this message
Steve Beattie (sbeattie) wrote :

Also lgtm, too. Would it be useful to have a mapping for <leader>n to set the priority to negligible?

If people don't like using `\` as the prfix key, use 'let mapleader=` in your vimrc to map it to a different character; I did

  let mapleader=","

to make the prefix character for custom macros match what I also define in mutt.

[Also, one recommendation for everybody to make reviewing easier, please at least copy the commit message or add a description of the change to the launchpad merge request, so that it shows up in the emails that get sent out, as the individual commit messages are not included with the attached diff in the emails.]

review: Approve

« Back to merge proposal