~pfsmorigo/review-tools:metalink_support

Branch merges

Propose for merging

Merged into review-tools:master at revision 43fe4dd767d67387bfad41a83143ab6f0faa0cf3

Emilia Torino: Approve on 2021-10-28

Alex Murray: Needs Fixing on 2021-09-16

Diff: 432 lines (+345/-0)

7 files modified

check-names.list (+1/-0)
reviewtools/common.py (+3/-0)
reviewtools/sr_common.py (+1/-0)
reviewtools/sr_lint.py (+26/-0)
reviewtools/tests/test_sr_lint.py (+52/-0)
snapcraft.yaml (+3/-0)
tests/test.sh.expected (+259/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

43fe4dd... by Paulo Flabiano Smorigo on 2021-10-28

Add check for links using a invalid list too

Signed-off-by: Paulo Flabiano Smorigo <email address hidden>

316a452... by Paulo Flabiano Smorigo on 2021-10-28

Add a check to verify if a link is string|list[string]

Signed-off-by: Paulo Flabiano Smorigo <email address hidden>

ef3075b... by Paulo Flabiano Smorigo on 2021-09-29

metalink: Remove regex checking and add expected test results

Signed-off-by: Paulo Flabiano Smorigo <email address hidden>

ae77083... by Paulo Flabiano Smorigo on 2021-09-14

Add support for links

Signed-off-by: Paulo Flabiano Smorigo <email address hidden>

e64e7a2... by Alex Murray on 2021-09-07

snapcraft.yaml: Add python3-ruamel.yaml to build/stage-packages

This is now required for the duplicate YAML key check

f9126ef... by Alex Murray on 2021-09-06

sr_common / test_sr_common: Fix flake8 / black style issues

bc98e6b... by Alex Murray on 2021-09-06

Makefile: Add python3-ruamel.yaml as a dependency

This is required for to check for duplicate YAML keys. Also change the
check-deb-deps target to use dpkg -s rather than dpkg -l since a package
can still be in the dpkg cache and hence show up via dpkg -l but dpkg -s
error's out if the package is not actually installed.

972d2d5... by Michael Vogt on 2021-08-31

sr-common: reject snaps that have duplicated yaml keys

This commit adds detection when yaml keys in maps are duplicated.
In YAML it is not allowed to have duplicated map keys like:
```
map:
 key:
 key:
```
But unfortunately py-yaml and go-yaml.v2 allow this and do not
warn or error. When moving to go-yaml.v3 we noticed this issue.

It is unclear if any real world snaps are affected by this but
we should make sure we at least to not get more.

cd6eede... by Alex Murray on 2021-09-06

Update debian/changelog for release

0951309... by Alex Murray on 2021-09-03

data/snapd-base-declaration.yaml: Update for latest changes in snapd

Adds ion-memory-control, microstack-support, sd-control and
snap-refresh-control