Merge lp:~pfalcon/linaro-license-protection/testfixes into lp:~linaro-automation/linaro-license-protection/trunk

Proposed by Paul Sokolovsky
Status: Merged
Merged at revision: 88
Proposed branch: lp:~pfalcon/linaro-license-protection/testfixes
Merge into: lp:~linaro-automation/linaro-license-protection/trunk
Diff against target: 36 lines (+2/-6)
2 files modified
license_protected_downloads/tests/test_buildinfo.py (+2/-0)
tests/__init__.py (+0/-6)
To merge this branch: bzr merge lp:~pfalcon/linaro-license-protection/testfixes
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
Linaro Infrastructure Pending
Review via email: mp+115972@code.launchpad.net

Description of the change

This fixes few small issues with tests I discovered running current testsuite.

To post a comment you must log in.
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Thanks for taking care. Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'license_protected_downloads/tests/test_buildinfo.py'
--- license_protected_downloads/tests/test_buildinfo.py 2012-07-11 11:56:10 +0000
+++ license_protected_downloads/tests/test_buildinfo.py 2012-07-20 12:44:20 +0000
@@ -32,6 +32,7 @@
32 self.assertEqual("0.1", build_info.getFormatVersion())32 self.assertEqual("0.1", build_info.getFormatVersion())
3333
34 def test_get_emptyField(self):34 def test_get_emptyField(self):
35 value = "notempty"
35 build_info = BuildInfo(self.buildinfo_file_path)36 build_info = BuildInfo(self.buildinfo_file_path)
36 for pair in build_info.file_info_array:37 for pair in build_info.file_info_array:
37 if "openid-launchpad-teams" in pair:38 if "openid-launchpad-teams" in pair:
@@ -40,6 +41,7 @@
40 self.assertFalse(value)41 self.assertFalse(value)
4142
42 def test_get(self):43 def test_get(self):
44 value = None
43 build_info = BuildInfo(self.buildinfo_file_path)45 build_info = BuildInfo(self.buildinfo_file_path)
44 for pair in build_info.file_info_array:46 for pair in build_info.file_info_array:
45 if "build-name" in pair:47 if "build-name" in pair:
4648
=== modified file 'tests/__init__.py'
--- tests/__init__.py 2012-07-11 13:49:21 +0000
+++ tests/__init__.py 2012-07-20 12:44:20 +0000
@@ -1,12 +1,6 @@
1import unittest1import unittest
2import tests.test_click_through_license
3import tests.test_publish_to_snapshots
42
53
6def test_suite():4def test_suite():
7 modules = [
8 tests.test_click_through_license,
9 tests.test_publish_to_snapshots,
10 ]
11 loader = unittest.TestLoader()5 loader = unittest.TestLoader()
12 return loader.discover('tests', top_level_dir='tests')6 return loader.discover('tests', top_level_dir='tests')

Subscribers

People subscribed via source and target branches