Merge lp:~pfalcon/linaro-license-protection/testfixes into lp:~linaro-automation/linaro-license-protection/trunk

Proposed by Paul Sokolovsky
Status: Merged
Merged at revision: 88
Proposed branch: lp:~pfalcon/linaro-license-protection/testfixes
Merge into: lp:~linaro-automation/linaro-license-protection/trunk
Diff against target: 36 lines (+2/-6)
2 files modified
license_protected_downloads/tests/test_buildinfo.py (+2/-0)
tests/__init__.py (+0/-6)
To merge this branch: bzr merge lp:~pfalcon/linaro-license-protection/testfixes
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
Linaro Infrastructure Pending
Review via email: mp+115972@code.launchpad.net

Description of the change

This fixes few small issues with tests I discovered running current testsuite.

To post a comment you must log in.
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Thanks for taking care. Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'license_protected_downloads/tests/test_buildinfo.py'
2--- license_protected_downloads/tests/test_buildinfo.py 2012-07-11 11:56:10 +0000
3+++ license_protected_downloads/tests/test_buildinfo.py 2012-07-20 12:44:20 +0000
4@@ -32,6 +32,7 @@
5 self.assertEqual("0.1", build_info.getFormatVersion())
6
7 def test_get_emptyField(self):
8+ value = "notempty"
9 build_info = BuildInfo(self.buildinfo_file_path)
10 for pair in build_info.file_info_array:
11 if "openid-launchpad-teams" in pair:
12@@ -40,6 +41,7 @@
13 self.assertFalse(value)
14
15 def test_get(self):
16+ value = None
17 build_info = BuildInfo(self.buildinfo_file_path)
18 for pair in build_info.file_info_array:
19 if "build-name" in pair:
20
21=== modified file 'tests/__init__.py'
22--- tests/__init__.py 2012-07-11 13:49:21 +0000
23+++ tests/__init__.py 2012-07-20 12:44:20 +0000
24@@ -1,12 +1,6 @@
25 import unittest
26-import tests.test_click_through_license
27-import tests.test_publish_to_snapshots
28
29
30 def test_suite():
31- modules = [
32- tests.test_click_through_license,
33- tests.test_publish_to_snapshots,
34- ]
35 loader = unittest.TestLoader()
36 return loader.discover('tests', top_level_dir='tests')

Subscribers

People subscribed via source and target branches