Merge lp:~pfalcon/linaro-android-frontend/lava-login-msg into lp:linaro-android-frontend

[Paul Sokolovsky]

In case we can't get test results from LAVA, suggest to users they should be logged in to it first. See lp:1006192

[lp:~pfalcon/linaro-android-frontend/lava-login-msg]

273. By Paul Sokolovsky on 2012-06-06

Open LAVA login in separate window, per asac's suggestion.

[Deepti B. Kalakeri (deeptik)]

On Wed, Jun 6, 2012 at 5:32 PM, Paul Sokolovsky
<email address hidden>wrote:

> Paul Sokolovsky has proposed merging
> lp:~pfalcon/linaro-android-frontend/lava-login-msg into
> lp:linaro-android-frontend.
>
> Requested reviews:
> Alexander Sack (asac)
> Linaro Infrastructure (linaro-infrastructure)
> Related bugs:
> Bug #1006192 in Linaro Android Infrastructure: "If user is not logged in
> into LAVA, error message is shown instead of test results"
> https://bugs.launchpad.net/linaro-android-infrastructure/+bug/1006192
>
> For more details, see:
>
> https://code.launchpad.net/~pfalcon/linaro-android-frontend/lava-login-msg/+merge/108924<https://code.launchpad.net/%7Epfalcon/linaro-android-frontend/lava-login-msg/+merge/108924>
>
> In case we can't get test results from LAVA, suggest to users they should
> be logged in to it first. See lp:1006192
>
> --
>
> https://code.launchpad.net/~pfalcon/linaro-android-frontend/lava-login-msg/+merge/108924<https://code.launchpad.net/%7Epfalcon/linaro-android-frontend/lava-login-msg/+merge/108924>
> Your team Linaro Infrastructure is requested to review the proposed merge
> of lp:~pfalcon/linaro-android-frontend/lava-login-msg into
> lp:linaro-android-frontend.
>
> === modified file 'static/buildDetails.js'
> --- static/buildDetails.js 2012-04-18 10:59:20 +0000
> +++ static/buildDetails.js 2012-06-06 12:01:20 +0000
> @@ -118,7 +118,11 @@
> on: {
> success: receivedJobJSON,
> failure: function (e) {
> - Y.one("#testresults").append("<br/>Could not load
> LAVA job data: " + e.msg);
> + // TODO: This should check for 403 first, but
> wouldn't
> + // work due to lp:1003817
> + Y.one("#testresults").append('<br/>Too see test
> results, please '
> + + '<a href="
> http://validation.linaro.org/lava-server/accounts/login/">login to
> LAVA</a>'
> + + ' (available to Linaro members).');
>

The instruction to login to lava seems good.
+1

> }
> }
>
>
>

--
Thanks and Regards,
Deepti
Infrastructure Team Member, Linaro Platform Teams
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog

[lp:~pfalcon/linaro-android-frontend/lava-login-msg]

274. By Paul Sokolovsky on 2012-06-07

Fix typo in LAVA login message.

=== modified file 'static/buildDetails.js'
--- static/buildDetails.js	2012-04-18 10:59:20 +0000
+++ static/buildDetails.js	2012-06-07 09:03:21 +0000
@@ -118,7 +118,12 @@
                 on: {
                     success: receivedJobJSON,
                     failure: function (e) {
-                        Y.one("#testresults").append("<br/>Could not load LAVA job data: " + e.msg);
+                        // TODO: This should check for 403 first, but wouldn't
+                        // work due to lp:1003817
+                        Y.one("#testresults").append('<br/>To see test results, please '
+                            + '<a target="_blank" href="http://validation.linaro.org/lava-server/accounts/login/">login '
+                            + 'to LAVA</a> and refresh this page. '
+                            + '(Test results are available to Linaro members).');
                     }
                 }
             }