Code review comment for lp:~pexego/account-financial-tools/adding_account_tools_from_extra_addons_to

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi Santi,

Thanks for the explanation on account_renumber. An easy solution will be to put the default menu in Administration and add one in your spanish localization in the account section, what do you think ?

For the account_admin_tools, you still using those "repair and check" fixes on version 6.1 ? Having a look on LP show that those trouble was discussed in 2010 and I can't remember that we face it in v6.1.

I don't want to be to restrictive, but honestly, I don't want to include a module in which we have >70% of the code that will not be used, what do you think ?

Other though here ?

Regards,

Joël

« Back to merge proposal