Code review comment for lp:~petermatulis/serverguide/serverguide-review-6.1

Revision history for this message
Ahmed Kamal (kim0) wrote :

An excellent review, thanks for greatly improving this chapter. I got a few little points to discuss:

- I notice a few shell scripts lost their execute permission. Can you please fix that
- On line 354 in this diff (/etc/ldap/slapd.d/ contents), I am not sure how this output was created. i.e. perhaps it's worth showing what command you used
- At the end of the chapter, you're including a list of man page links. Would it be a good idea to remove "oneiric" from the URL, example: http://manpages.ubuntu.com/manpages/en/man1/ldapadduser.1.html It seems the website does the right thing and always redirects you to the latest release

review: Needs Fixing

« Back to merge proposal