Grafana Charm

Code review comment for ~peter-sabaini/charm-grafana:test-fixes-race-cleanup

  1. Git
  2. lp:~peter-sabaini/charm-grafana
  3. test-fixes-race-cleanup
  4. Merge into master
Revision history for this message
Drew Freiberger (afreiberger) wrote :

Regarding the python3-pip apt list command:

https://git.launchpad.net/~peter-sabaini/charm-grafana/tree/src/lib/charms/layer/grafana.py?h=test-fixes-race-cleanup#n181

Update this to subprocess.getoutput() instead of check_output to toss out the exception handling if it's uninstalled. Or add a try: except: return False kind of thing to handle these package install exceptions.

« Back to merge proposal