Code review comment for lp:~peter-pearse/ubuntu/natty/python2.6/prop004

Revision history for this message
Peter Pearse (peter-pearse) wrote :

No need to set -fPIC now that the make install gets the correct config files.
It was needed when the static python binary was being built & installed using the dynamic libpython

The following part of the patch ensures the static python is built with the static library or vice versa,

622 ifeq ($(with_interp),static)
623 - $(MAKE) -C $(buildd_static) install prefix=$(CURDIR)/$(d)/usr
624 + ifneq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))
625 + @echo "Build python should use the new pyconfig.h"
626 + cp $(buildd_static)/pyconfig.h $(buildd_cross)/pyconfig.h
627 + cp $(buildd_static)/Makefile $(buildd_cross)/Makefile
628 + endif
629 + $(MAKE) -C $(buildd_static) install prefix=$(CURDIR)/$(d)/usr $(CROSS)
630 else
631 - $(MAKE) -C $(buildd_shared) install prefix=$(CURDIR)/$(d)/usr
632 + ifneq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))
633 + @echo "Build python should use the new pyconfig.h"
634 + cp $(buildd_shared)/pyconfig.h $(buildd_cross)/pyconfig.h
635 + cp $(buildd_shared)/Makefile $(buildd_cross)/Makefile
636 + endif
637 + $(MAKE) -C $(buildd_shared) install prefix=$(CURDIR)/$(d)/usr $(CROSS)
638 endif

« Back to merge proposal