Code review comment for lp:~peter-pearse/ubuntu/natty/ncurses/prop001

Revision history for this message
Steve Langasek (vorlon) wrote :

This seems to conflict with the upstream intent, however, which is that -L/lib is needed on certain Linux distributions. If it's no longer needed then that part should definitely be fixed upstream.

Is it sufficient to *prepend* the cross-compilation path? i.e., have both
    CF_ADD_LIBDIR(/usr/$ac_cv_host_alias/lib)
and
    CF_ADD_LIBDIR(/lib)
?

I also don't think we should be adding this path except in cases where we know we're cross-compiling; can you please fix this to be conditional on host != build?

review: Needs Fixing

« Back to merge proposal