Merge lp:~peter-pearse/ubuntu/natty/guile-1.8/prop001 into lp:ubuntu/natty/guile-1.8

Proposed by Peter Pearse
Status: Work in progress
Proposed branch: lp:~peter-pearse/ubuntu/natty/guile-1.8/prop001
Merge into: lp:ubuntu/natty/guile-1.8
Diff against target: 107 lines (+75/-0)
4 files modified
debian/changelog (+8/-0)
debian/patches/cross.diff (+62/-0)
debian/patches/series (+1/-0)
debian/rules (+4/-0)
To merge this branch: bzr merge lp:~peter-pearse/ubuntu/natty/guile-1.8/prop001
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Review via email: mp+51750@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

Is there a reason this can't be implemented using AC_CACHE_CHECK(), instead of referencing the variable directly in configure.in?

review: Needs Fixing

Unmerged revisions

22. By Peter Pearse

Add cache variable for cross build configure pthread_attr_getstack test.
Dont make check when cross building.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-02-17 14:19:09 +0000
+++ debian/changelog 2011-03-01 14:13:03 +0000
@@ -1,3 +1,11 @@
1guile-1.8 (1.8.7+1-3ubuntu4) maverick; urgency=low
2
3 * Add cache variable for cross build configure pthread_attr_getstack
4 test.
5 * Dont make check when cross building.
6
7 -- Peter Pearse <peter.pearse@linaro.org> Tue, 01 Mar 2011 14:09:04 +0000
8
1guile-1.8 (1.8.7+1-3ubuntu3) natty; urgency=low9guile-1.8 (1.8.7+1-3ubuntu3) natty; urgency=low
210
3 * Backport from upstream:11 * Backport from upstream:
412
=== added file 'debian/patches/cross.diff'
--- debian/patches/cross.diff 1970-01-01 00:00:00 +0000
+++ debian/patches/cross.diff 2011-03-01 14:13:03 +0000
@@ -0,0 +1,62 @@
1diff -purN g/configure g_p//configure
2--- g/configure 2011-03-01 13:56:29.000000000 +0000
3+++ g_p//configure 2011-03-01 14:01:25.000000000 +0000
4@@ -18855,6 +18855,9 @@ fi
5
6 ## Check whether pthread_attr_getstack works for the main thread
7
8+# Work round for cross build
9+if test -z "$ac_cv_pthread_attr_getstack_works"; then
10+
11 if test "$with_threads" = pthreads; then
12
13 { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether pthread_attr_getstack works for the main thread" >&5
14@@ -18914,6 +18917,19 @@ $as_echo "$works" >&6; }
15
16 fi # with_threads=pthreads
17
18+else
19+ if test "$ac_cv_pthread_attr_getstack_works" = yes; then
20+
21+cat >>confdefs.h <<\_ACEOF
22+#define PTHREAD_ATTR_GETSTACK_WORKS 1
23+_ACEOF
24+$as_echo "$as_me: #define PTHREAD_ATTR_GETSTACK_WORKS 1 - from ac_cv_pthread_attr_getstack_works" >&5
25+$as_echo "$as_me: #define PTHREAD_ATTR_GETSTACK_WORKS 1 - from ac_cv_pthread_attr_getstack_works" >&5
26+ else
27+$as_echo "$as_me: #undefine PTHREAD_ATTR_GETSTACK_WORKS - from ac_cv_pthread_attr_getstack_works" >&5
28+$as_echo "$as_me: #undefine PTHREAD_ATTR_GETSTACK_WORKS - from ac_cv_pthread_attr_getstack_works" >&5
29+ fi
30+fi # Cross build work round
31
32 ## Cross building
33 if test "$cross_compiling" = "yes"; then
34diff -purN g/configure.in g_p//configure.in
35--- g/configure.in 2011-03-01 13:56:29.000000000 +0000
36+++ g_p//configure.in 2011-03-01 14:01:25.000000000 +0000
37@@ -1369,6 +1369,9 @@ AM_CONDITIONAL([BUILD_PTHREAD_SUPPORT],
38
39 ## Check whether pthread_attr_getstack works for the main thread
40
41+# Work round for cross build
42+if test -z "$ac_cv_pthread_attr_getstack_works": then
43+
44 if test "$with_threads" = pthreads; then
45
46 AC_MSG_CHECKING(whether pthread_attr_getstack works for the main thread)
47@@ -1408,7 +1411,14 @@ CFLAGS="$old_CFLAGS"
48 AC_MSG_RESULT($works)
49
50 fi # with_threads=pthreads
51-
52+else
53+ if test "$ac_cv_pthread_attr_getstack_works" = yes; then
54+ AC_DEFINE(PTHREAD_ATTR_GETSTACK_WORKS, [1], [Define when pthread_att_get_stack works for the main thread])
55+ AC_MSG_RESULT("#define PTHREAD_ATTR_GETSTACK_WORKS 1 - from ac_cv_pthread_attr_getstack_works")
56+ else
57+ AC_MSG_RESULT("#undef PTHREAD_ATTR_GETSTACK_WORKS - from ac_cv_pthread_attr_getstack_works")
58+ fi
59+fi # Cross build work round
60
61 ## Cross building
62 if test "$cross_compiling" = "yes"; then
063
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-02-17 14:19:09 +0000
+++ debian/patches/series 2011-03-01 14:13:03 +0000
@@ -6,3 +6,4 @@
6fix-make-check-for-new-libltdl.diff6fix-make-check-for-new-libltdl.diff
7doc-new-gcc.diff7doc-new-gcc.diff
8autofiles.diff8autofiles.diff
9cross.diff
910
=== modified file 'debian/rules'
--- debian/rules 2010-01-19 02:27:06 +0000
+++ debian/rules 2011-03-01 14:13:03 +0000
@@ -309,7 +309,11 @@
309debian/stamp/build: debian/stamp/config309debian/stamp/build: debian/stamp/config
310 $(checkdir)310 $(checkdir)
311 $(MAKE) CFLAGS="$(deb_cflags) -Wno-error"311 $(MAKE) CFLAGS="$(deb_cflags) -Wno-error"
312ifeq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
312 unset SHELL && $(MAKE) check313 unset SHELL && $(MAKE) check
314else
315 @echo "No check when cross building"
316endif
313 mkdir -p $(dir $@) && touch $@317 mkdir -p $(dir $@) && touch $@
314318
315clean:319clean:

Subscribers

People subscribed via source and target branches

to all changes: