Merge lp:~peter-pearse/ubuntu/natty/guile-1.8/prop001 into lp:ubuntu/natty/guile-1.8

Proposed by Peter Pearse
Status: Work in progress
Proposed branch: lp:~peter-pearse/ubuntu/natty/guile-1.8/prop001
Merge into: lp:ubuntu/natty/guile-1.8
Diff against target: 107 lines (+75/-0)
4 files modified
debian/changelog (+8/-0)
debian/patches/cross.diff (+62/-0)
debian/patches/series (+1/-0)
debian/rules (+4/-0)
To merge this branch: bzr merge lp:~peter-pearse/ubuntu/natty/guile-1.8/prop001
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Review via email: mp+51750@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

Is there a reason this can't be implemented using AC_CACHE_CHECK(), instead of referencing the variable directly in configure.in?

review: Needs Fixing

Unmerged revisions

22. By Peter Pearse

Add cache variable for cross build configure pthread_attr_getstack test.
Dont make check when cross building.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-02-17 14:19:09 +0000
3+++ debian/changelog 2011-03-01 14:13:03 +0000
4@@ -1,3 +1,11 @@
5+guile-1.8 (1.8.7+1-3ubuntu4) maverick; urgency=low
6+
7+ * Add cache variable for cross build configure pthread_attr_getstack
8+ test.
9+ * Dont make check when cross building.
10+
11+ -- Peter Pearse <peter.pearse@linaro.org> Tue, 01 Mar 2011 14:09:04 +0000
12+
13 guile-1.8 (1.8.7+1-3ubuntu3) natty; urgency=low
14
15 * Backport from upstream:
16
17=== added file 'debian/patches/cross.diff'
18--- debian/patches/cross.diff 1970-01-01 00:00:00 +0000
19+++ debian/patches/cross.diff 2011-03-01 14:13:03 +0000
20@@ -0,0 +1,62 @@
21+diff -purN g/configure g_p//configure
22+--- g/configure 2011-03-01 13:56:29.000000000 +0000
23++++ g_p//configure 2011-03-01 14:01:25.000000000 +0000
24+@@ -18855,6 +18855,9 @@ fi
25+
26+ ## Check whether pthread_attr_getstack works for the main thread
27+
28++# Work round for cross build
29++if test -z "$ac_cv_pthread_attr_getstack_works"; then
30++
31+ if test "$with_threads" = pthreads; then
32+
33+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether pthread_attr_getstack works for the main thread" >&5
34+@@ -18914,6 +18917,19 @@ $as_echo "$works" >&6; }
35+
36+ fi # with_threads=pthreads
37+
38++else
39++ if test "$ac_cv_pthread_attr_getstack_works" = yes; then
40++
41++cat >>confdefs.h <<\_ACEOF
42++#define PTHREAD_ATTR_GETSTACK_WORKS 1
43++_ACEOF
44++$as_echo "$as_me: #define PTHREAD_ATTR_GETSTACK_WORKS 1 - from ac_cv_pthread_attr_getstack_works" >&5
45++$as_echo "$as_me: #define PTHREAD_ATTR_GETSTACK_WORKS 1 - from ac_cv_pthread_attr_getstack_works" >&5
46++ else
47++$as_echo "$as_me: #undefine PTHREAD_ATTR_GETSTACK_WORKS - from ac_cv_pthread_attr_getstack_works" >&5
48++$as_echo "$as_me: #undefine PTHREAD_ATTR_GETSTACK_WORKS - from ac_cv_pthread_attr_getstack_works" >&5
49++ fi
50++fi # Cross build work round
51+
52+ ## Cross building
53+ if test "$cross_compiling" = "yes"; then
54+diff -purN g/configure.in g_p//configure.in
55+--- g/configure.in 2011-03-01 13:56:29.000000000 +0000
56++++ g_p//configure.in 2011-03-01 14:01:25.000000000 +0000
57+@@ -1369,6 +1369,9 @@ AM_CONDITIONAL([BUILD_PTHREAD_SUPPORT],
58+
59+ ## Check whether pthread_attr_getstack works for the main thread
60+
61++# Work round for cross build
62++if test -z "$ac_cv_pthread_attr_getstack_works": then
63++
64+ if test "$with_threads" = pthreads; then
65+
66+ AC_MSG_CHECKING(whether pthread_attr_getstack works for the main thread)
67+@@ -1408,7 +1411,14 @@ CFLAGS="$old_CFLAGS"
68+ AC_MSG_RESULT($works)
69+
70+ fi # with_threads=pthreads
71+-
72++else
73++ if test "$ac_cv_pthread_attr_getstack_works" = yes; then
74++ AC_DEFINE(PTHREAD_ATTR_GETSTACK_WORKS, [1], [Define when pthread_att_get_stack works for the main thread])
75++ AC_MSG_RESULT("#define PTHREAD_ATTR_GETSTACK_WORKS 1 - from ac_cv_pthread_attr_getstack_works")
76++ else
77++ AC_MSG_RESULT("#undef PTHREAD_ATTR_GETSTACK_WORKS - from ac_cv_pthread_attr_getstack_works")
78++ fi
79++fi # Cross build work round
80+
81+ ## Cross building
82+ if test "$cross_compiling" = "yes"; then
83
84=== modified file 'debian/patches/series'
85--- debian/patches/series 2011-02-17 14:19:09 +0000
86+++ debian/patches/series 2011-03-01 14:13:03 +0000
87@@ -6,3 +6,4 @@
88 fix-make-check-for-new-libltdl.diff
89 doc-new-gcc.diff
90 autofiles.diff
91+cross.diff
92
93=== modified file 'debian/rules'
94--- debian/rules 2010-01-19 02:27:06 +0000
95+++ debian/rules 2011-03-01 14:13:03 +0000
96@@ -309,7 +309,11 @@
97 debian/stamp/build: debian/stamp/config
98 $(checkdir)
99 $(MAKE) CFLAGS="$(deb_cflags) -Wno-error"
100+ifeq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
101 unset SHELL && $(MAKE) check
102+else
103+ @echo "No check when cross building"
104+endif
105 mkdir -p $(dir $@) && touch $@
106
107 clean:

Subscribers

People subscribed via source and target branches

to all changes: