Merge lp:~peter-pearse/ubuntu/natty/gmp/prop001 into lp:ubuntu/natty/gmp

Proposed by Peter Pearse
Status: Merged
Merged at revision: 27
Proposed branch: lp:~peter-pearse/ubuntu/natty/gmp/prop001
Merge into: lp:ubuntu/natty/gmp
Diff against target: 37 lines (+9/-3)
2 files modified
debian/changelog (+6/-0)
debian/rules (+3/-3)
To merge this branch: bzr merge lp:~peter-pearse/ubuntu/natty/gmp/prop001
Reviewer Review Type Date Requested Status
Steve Langasek Pending
Review via email: mp+51734@code.launchpad.net

Description of the change

Strip spaces from the GNU_TYPES otherwise later debhelper utilities get confused.
Pass --target for cross builds.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

Rather than calling $(strip), I think we might just remove the unnecessary whitespace in debian/rules.

Also, we can simply do without this $(subst) at all, it's completely unnecessary on Debian or Ubuntu for the past 4 years or so. Fixed up and merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-02-25 07:07:18 +0000
+++ debian/changelog 2011-03-01 11:51:59 +0000
@@ -1,3 +1,9 @@
1gmp (2:4.3.2+dfsg-1ubuntu2) natty; urgency=low
2
3 * For cross builds, strip GNU_TYPES & pass --target
4
5 -- Peter Pearse <peter.pearse@linaro.org> Tue, 01 Mar 2011 11:47:29 +0000
6
1gmp (2:4.3.2+dfsg-1ubuntu1) lucid; urgency=low7gmp (2:4.3.2+dfsg-1ubuntu1) lucid; urgency=low
28
3 * Support for thumb2 instructions in arm assembler (LP: #51372)9 * Support for thumb2 instructions in arm assembler (LP: #51372)
410
=== modified file 'debian/rules'
--- debian/rules 2010-02-25 07:07:18 +0000
+++ debian/rules 2011-03-01 11:51:59 +0000
@@ -16,8 +16,8 @@
16endif16endif
1717
18DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)18DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
19export DEB_HOST_GNU_TYPE := $(subst i386,i486, $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE))19export DEB_HOST_GNU_TYPE := $(strip $(subst i386,i486, $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)))
20export DEB_BUILD_GNU_TYPE := $(subst i386,i486, $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE))20export DEB_BUILD_GNU_TYPE := $(strip $(subst i386,i486, $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)))
2121
22MAKE_CHECK = : disabled make check22MAKE_CHECK = : disabled make check
23ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))23ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
@@ -52,7 +52,7 @@
52 confflags_build += --build $(DEB_BUILD_GNU_TYPE)52 confflags_build += --build $(DEB_BUILD_GNU_TYPE)
53else53else
54 AR = $(DEB_HOST_GNU_TYPE)-ar54 AR = $(DEB_HOST_GNU_TYPE)-ar
55 confflags_build += --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE)55 confflags_build += --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE) --target $(DEB_HOST_GNU_TYPE)
56endif56endif
5757
58ifneq (,$(findstring $(DEB_HOST_ARCH), amd64 ppc64 kfreebsd-amd64))58ifneq (,$(findstring $(DEB_HOST_ARCH), amd64 ppc64 kfreebsd-amd64))

Subscribers

People subscribed via source and target branches

to all changes: