Ubuntu
db4.8 package

Code review comment for lp:~peter-pearse/ubuntu/natty/db4.8/prop001

  1. Natty (11.04)
  2. prop001
  3. Merge into natty
Revision history for this message
Steve Langasek (vorlon) wrote :

+ CONFIGURE_VARS = CC=$(DEB_HOST_GNU_TYPE)-gcc CXX=$(DEB_HOST_GNU_TYPE)-g++ CFLAGS="$(CFLAGS)" CPPFLAGS="-I/usr/$(DEB_HOST_GNU_TYPE)/usr/include/tcl8.5"

This path looks wrong. Shouldn't this be CPPFLAGS="-I/usr/$(DEB_HOST_GNU_TYPE)/include/tcl8.5"? Does something need to be fixed in the tcl8.5 crossing so that this installs to the right place?

Everything else looks spot-on!

review: Needs Fixing

« Back to merge proposal