Code review comment for lp:~pete-woods/unity-api/add-glib-assigner-class

Revision history for this message
Pete Woods (pete-woods) wrote :

The only thing really bothering me now is the dual implementations of shared and unique assigners. If you could conditionally compile different stuff into the deleter depending of if the template argument was a uptr or sptr then you could collapse this down. You'd also be able to collapse the two assign_sptr and assign_uptr methods at the same time.

« Back to merge proposal