Merge lp:~pete-woods/camera-app/file-based-infographics into lp:camera-app

Proposed by Pete Woods
Status: Needs review
Proposed branch: lp:~pete-woods/camera-app/file-based-infographics
Merge into: lp:camera-app
Prerequisite: lp:~pete-woods/camera-app/handle-quit-signal
Diff against target: 80 lines (+11/-4)
5 files modified
CMakeLists.txt (+6/-0)
camera-apparmor.json (+0/-1)
debian/camera-app.install (+1/-0)
debian/control (+1/-1)
manifest.json (+3/-2)
To merge this branch: bzr merge lp:~pete-woods/camera-app/file-based-infographics
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+210573@code.launchpad.net

Commit message

Enable the infographic source hook for file based infographics

Description of the change

Enable the infographic source hook for file based infographics

To post a comment you must log in.
Revision history for this message
Pete Woods (pete-woods) wrote :
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Florian Boucault (fboucault) wrote :

Who reviewed this?

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

As you can see, no one. But please do, we want to land the new style infographics finally.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

344. By Pete Woods

Add support for file based infographics

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2014-07-31 18:41:17 +0000
+++ CMakeLists.txt 2014-08-06 11:39:49 +0000
@@ -43,6 +43,11 @@
43 set(CAMERA_ICON "camera-app")43 set(CAMERA_ICON "camera-app")
44 set(CAMERA_APP_DIR ${CMAKE_INSTALL_DATADIR}/${CAMERA_APP})44 set(CAMERA_APP_DIR ${CMAKE_INSTALL_DATADIR}/${CAMERA_APP})
45 set(DESKTOP_EXEC ${CAMERA_APP})45 set(DESKTOP_EXEC ${CAMERA_APP})
46 install(
47 FILES "camera-usermetrics.json"
48 DESTINATION "${CMAKE_INSTALL_DATADIR}/libusermetrics/sources/"
49 RENAME "com.ubuntu.camera.json"
50 )
46endif(CLICK_MODE)51endif(CLICK_MODE)
4752
48configure_file(config.h.in ${CMAKE_CURRENT_BINARY_DIR}/config.h @ONLY)53configure_file(config.h.in ${CMAKE_CURRENT_BINARY_DIR}/config.h @ONLY)
@@ -119,6 +124,7 @@
119 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json124 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json
120 DESTINATION ${CMAKE_INSTALL_PREFIX})125 DESTINATION ${CMAKE_INSTALL_PREFIX})
121 install(FILES camera-apparmor.json126 install(FILES camera-apparmor.json
127 camera-usermetrics.json
122 DESTINATION ${CMAKE_INSTALL_PREFIX})128 DESTINATION ${CMAKE_INSTALL_PREFIX})
123 install(FILES camera-contenthub.json129 install(FILES camera-contenthub.json
124 DESTINATION ${CMAKE_INSTALL_PREFIX})130 DESTINATION ${CMAKE_INSTALL_PREFIX})
125131
=== modified file 'camera-apparmor.json'
--- camera-apparmor.json 2014-07-31 18:41:17 +0000
+++ camera-apparmor.json 2014-08-06 11:39:49 +0000
@@ -5,7 +5,6 @@
5 "camera",5 "camera",
6 "audio",6 "audio",
7 "video",7 "video",
8 "usermetrics",
9 "content_exchange",8 "content_exchange",
10 "content_exchange_source",9 "content_exchange_source",
11 "location"10 "location"
1211
=== added file 'camera-usermetrics.json'
=== modified file 'debian/camera-app.install'
--- debian/camera-app.install 2014-07-29 16:44:02 +0000
+++ debian/camera-app.install 2014-08-06 11:39:49 +0000
@@ -5,4 +5,5 @@
5usr/share/camera-app/*.js5usr/share/camera-app/*.js
6usr/share/camera-app/assets/*6usr/share/camera-app/assets/*
7usr/share/icons7usr/share/icons
8usr/share/libusermetrics
8usr/share/locale/*/LC_MESSAGES/camera-app.mo9usr/share/locale/*/LC_MESSAGES/camera-app.mo
910
=== modified file 'debian/control'
--- debian/control 2014-07-16 14:24:12 +0000
+++ debian/control 2014-08-06 11:39:49 +0000
@@ -18,7 +18,7 @@
18 qtdeclarative5-usermetrics0.1,18 qtdeclarative5-usermetrics0.1,
19 qtdeclarative5-ubuntu-content0.1,19 qtdeclarative5-ubuntu-content0.1,
20 qtmultimedia5-dev,20 qtmultimedia5-dev,
21 libusermetricsinput1-dev,21 libusermetricsinput1-dev (>= 1.2.0),
22 gettext,22 gettext,
23 dh-translations,23 dh-translations,
24Standards-Version: 3.9.524Standards-Version: 3.9.5
2525
=== modified file 'manifest.json'
--- manifest.json 2014-07-31 18:41:17 +0000
+++ manifest.json 2014-08-06 11:39:49 +0000
@@ -6,7 +6,8 @@
6 "camera": {6 "camera": {
7 "apparmor": "camera-apparmor.json",7 "apparmor": "camera-apparmor.json",
8 "desktop": "@DESKTOP_FILE@",8 "desktop": "@DESKTOP_FILE@",
9 "content-hub": "camera-contenthub.json"9 "content-hub": "camera-contenthub.json",
10 "usermetrics": "camera-usermetrics.json"
10 }11 }
11 },12 },
12 "icon": "@CAMERA_ICON@",13 "icon": "@CAMERA_ICON@",
@@ -21,4 +22,4 @@
21 "x-test": {22 "x-test": {
22 "autopilot": "@AUTOPILOT_DIR@"23 "autopilot": "@AUTOPILOT_DIR@"
23 }24 }
24}
25\ No newline at end of file25\ No newline at end of file
26}

Subscribers

People subscribed via source and target branches