Code review comment for lp:~percona-toolkit-dev/percona-toolkit/pxc-pt-mysql-summary

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

112 - for pid in $( grep '/mysqld' "$mysqld_instances" | awk '/^ .*[0-9]/{print $1}' ); do
113 + for pid in $( grep '/mysqld' "$mysqld_instances" | awk '/^.*[0-9]/{print $1}' ); do

Isn't that changing the meaning of the regex? The original was "a space plus any characters", now it's just "any characters".

not ok 9 - --read-samples works for t/pt-mysql-summary/temp007
# Failed test '--read-samples works for t/pt-mysql-summary/temp007'
# at pt-mysql-summary.t line 67.
# 51,52c51,52
# < Bytes_received 3e+09 35000 200
# < Bytes_sent 3e+09 35000 2250
# ---
# > Bytes_received 3000000000 35000 200
# > Bytes_sent 3000000000 35000 2250

Need to coerce away the e notation.

review: Needs Fixing

« Back to merge proposal